Explorar el Código

fix unit-tests

Olivier Massot hace 4 años
padre
commit
cc983e53b1

+ 1 - 0
ot_core/Classes/Controller/SelectedSiteController.php

@@ -39,6 +39,7 @@ class SelectedSiteController extends ActionController
     /**
      *
      * @throws \TYPO3\CMS\Extbase\Mvc\Exception\StopActionException
+     * @throws \Opentalent\OtCore\Exception\NoSuchWebsiteException
      */
     protected function callActionMethod() {
 

+ 8 - 2
ot_core/Tests/Unit/Controller/SelectedSiteControllerTest.php

@@ -5,7 +5,10 @@ namespace Opentalent\OtCore\Tests\Unit\Controller;
 use Nimut\TestingFramework\TestCase\UnitTestCase;
 use Opentalent\OtCore\Controller\SelectedSiteController;
 use Opentalent\OtCore\Exception\NoSiteSelected;
+use Opentalent\OtCore\Exception\NoSuchWebsiteException;
 use Opentalent\OtCore\Website\OtPageRepository;
+use Opentalent\OtCore\Website\OtWebsiteRepository;
+use Prophecy\Argument;
 
 class SelectedSiteControllerTest extends UnitTestCase
 {
@@ -25,6 +28,11 @@ class SelectedSiteControllerTest extends UnitTestCase
         }
         $otPageRepository->getCurrentBeUserMountpoints()->shouldBeCalled()->willReturn($mountpoints);
         $this->controller->injectOtPageRepository($otPageRepository->reveal());
+
+        $otWebsiteRepository = $this->prophesize(OtWebsiteRepository::class);
+        $otWebsiteRepository->getWebsiteByPageUid(Argument::type('integer'))->willReturn(['uid' => 1, 'title' => 'Foo']);
+        $this->controller->injectOtWebsiteRepository($otWebsiteRepository->reveal());
+
     }
 
     private function callActionMethodProxy() {
@@ -44,8 +52,6 @@ class SelectedSiteControllerTest extends UnitTestCase
         return $currentRootUidProperty->getValue($this->controller);
     }
 
-
-
     /**
      * If the current Be-user has only one website mounted,
      * then the currentRootUid should be this website root uid

+ 3 - 6
ot_core/Tests/Unit/Website/OtPageRepositoryTest.php

@@ -13,7 +13,6 @@ class OtPageRepositoryTest extends UnitTestCase
     protected $pageService;
     protected $pageRepository;
     protected $connectionPool;
-    protected $siteFinder;
     protected $pageFixtures;
     protected $otPageRepository;
 
@@ -22,7 +21,6 @@ class OtPageRepositoryTest extends UnitTestCase
         $this->pageService = $this->prophesize(\FluidTYPO3\Vhs\Service\PageService::class);
         $this->pageRepository = $this->prophesize(\TYPO3\CMS\Frontend\Page\PageRepository::class);
         $this->connectionPool = $this->prophesize(\TYPO3\CMS\Core\Database\ConnectionPool::class);
-        $this->siteFinder = $this->prophesize(\TYPO3\CMS\Core\Site\SiteFinder::class);
 
         // Fixtures
         $this->pageFixtures = new PageFixtures();
@@ -38,7 +36,6 @@ class OtPageRepositoryTest extends UnitTestCase
         $this->otPageRepository->injectPageService($this->pageService->reveal());
         $this->otPageRepository->injectPageRepository($this->pageRepository->reveal());
         $this->otPageRepository->injectConnectionPool($this->connectionPool->reveal());
-        $this->otPageRepository->injectSiteFinder($this->siteFinder->reveal());
     }
 
     /**
@@ -80,7 +77,7 @@ class OtPageRepositoryTest extends UnitTestCase
         $root_line = $this->pageFixtures->getRootlineFor($page_uid);
 
         $this->pageService->getRootLine($page_uid)->shouldBeCalled()->willReturn($root_line);
-        $this->pageRepository->getPage($root_uid)->shouldBeCalled()->willReturn($root_page);
+        $this->pageRepository->getPage($root_uid, true)->shouldBeCalled()->willReturn($root_page);
         $this->injectProphecies();
 
         // Test
@@ -104,7 +101,7 @@ class OtPageRepositoryTest extends UnitTestCase
         $root_line = $this->pageFixtures->getRootlineFor($root_uid);
 
         $this->pageService->getRootLine($root_uid)->shouldBeCalled()->willReturn($root_line);
-        $this->pageRepository->getPage($root_uid)->shouldBeCalled()->willReturn($root_page);
+        $this->pageRepository->getPage($root_uid, true)->shouldBeCalled()->willReturn($root_page);
         $this->injectProphecies();
 
         // Test
@@ -279,7 +276,7 @@ class OtPageRepositoryTest extends UnitTestCase
         $root_line = $this->pageFixtures->getRootlineFor($page_uid);
 
         $this->pageService->getRootLine($page_uid)->shouldBeCalled()->willReturn($root_line);
-        $this->pageRepository->getPage($root_uid)->shouldBeCalled()->willReturn($root_page);
+        $this->pageRepository->getPage($root_uid, true)->shouldBeCalled()->willReturn($root_page);
         $this->injectProphecies();
 
         $GLOBALS['_POST'] = ['id' => $page_uid];