minor fixes

ot_templating/Resources/Private/Partials/Classic/ShareBar.html

@@ -13,7 +13,13 @@
     <i class="fab fa-facebook" style="color: #129af6"></i> Facebook
   </a>
 
-  <a href="#">
+  <a href="#"
+     onclick="
+      window.open(
+        'https://www.twitter.com/share?url='+encodeURIComponent(location.href),
+        'twitter-share-dialog',
+        'width=626,height=436');
+      return false;">
     <i class="fab fa-twitter" style="color: #1da1f2"></i> Twitter
   </a>
 </div>

ot_templating/Resources/Private/Partials/Modern/ShareBar.html

@@ -17,7 +17,7 @@
      onclick="
       window.open(
         'https://www.twitter.com/share?url='+encodeURIComponent(location.href),
-        'facebook-share-dialog',
+        'twitter-share-dialog',
         'width=626,height=436');
       return false;">
     <i class="fa fa-twitter" style="color: #1da1f2"></i> Twitter