gitflow-feature-stash: fix_unit_tests

ot_core/Tests/Unit/Domain/Repository/BaseApiRepositoryTest.php

@@ -12,8 +12,8 @@ use Opentalent\OtCore\Exception\ApiRequestException;
  * @package Opentalent\OtCore\Tests\Unit\Domain\Repository
  */
 class ConcreteBaseApiRepository extends BaseApiRepository {
-    protected function memberToObject(array $member) { return $member; }
-    public function getApiFirstRecord(array $params = [], $forceUri = null) { return parent::getApiFirstRecord($params, $forceUri); }
+    protected function memberToObject(array $record): ?object { return (object)$record; }
+    public function getApiFirstRecord(array $params = [], $forceUri = null): object { return parent::getApiFirstRecord($params, $forceUri); }
     public function getApiRecords($params = [], $forceUri = null): ApiPagedCollection { return parent::getApiRecords($params, $forceUri); }
 }
 
@@ -35,7 +35,7 @@ class BaseApiRepositoryTest extends AbstractApiRepositoryTestCase
 
         $actual = $this->repository->getApiFirstRecord($params, $base_uri);
 
-        $this->assertEquals('PortailOrganization', $actual['@type']);
+        $this->assertEquals('PortailOrganization', $actual->{'@type'});
     }
 
     /**
@@ -52,6 +52,6 @@ class BaseApiRepositoryTest extends AbstractApiRepositoryTestCase
 
         $actual = $this->repository->getApiRecords($params, $base_uri);
 
-        $this->assertEquals('PortailOrganization', $actual->getMembers()[0]['@type']);
+        $this->assertEquals('PortailOrganization', $actual->getMembers()[0]->{'@type'});
     }
 }

ot_core/Tests/Unit/Website/OtPageRepositoryTest.php

@@ -75,8 +75,8 @@ class OtPageRepositoryTest extends UnitTestCase
         $root_uid = 200;
         $root_page = $this->pageFixtures->getByUid($root_uid);
 
-        $this->pageRepository->getPage_noCheck($page_uid, true)->shouldBeCalled()->willReturn($page);
-        $this->pageRepository->getPage_noCheck($root_uid, true)->shouldBeCalled()->willReturn($root_page);
+        $this->pageRepository->getPage_noCheck($page_uid)->shouldBeCalled()->willReturn($page);
+        $this->pageRepository->getPage_noCheck($root_uid)->shouldBeCalled()->willReturn($root_page);
         $this->injectProphecies();
 
         // Test
@@ -97,7 +97,7 @@ class OtPageRepositoryTest extends UnitTestCase
         $root_uid = 200;
         $root_page = $this->pageFixtures->getByUid($root_uid);
 
-        $this->pageRepository->getPage_noCheck($root_uid, true)->shouldBeCalled()->willReturn($root_page);
+        $this->pageRepository->getPage_noCheck($root_uid)->shouldBeCalled()->willReturn($root_page);
         $this->injectProphecies();
 
         // Test
@@ -118,8 +118,8 @@ class OtPageRepositoryTest extends UnitTestCase
         $page_uid = 100;
         $page = $this->pageFixtures->getByUid($page_uid);
 
-        $this->pageRepository->getPage_noCheck($page_uid, true)->shouldBeCalled()->willReturn($page);
-        $this->pageRepository->getPage_noCheck(0, true)->shouldBeCalled()->willReturn([]);
+        $this->pageRepository->getPage_noCheck($page_uid)->shouldBeCalled()->willReturn($page);
+        $this->pageRepository->getPage_noCheck(0)->shouldBeCalled()->willReturn([]);
         $this->injectProphecies();
 
         // Test
@@ -245,7 +245,7 @@ class OtPageRepositoryTest extends UnitTestCase
 
         $page = $this->pageFixtures->getByUid($page_uid);
 
-        $this->pageRepository->getPage($page_uid, true)->willReturn($page);
+        $this->pageRepository->getPage_noCheck($page_uid)->willReturn($page);
         $this->otPageRepository->injectPageRepository($this->pageRepository->reveal());
 
         // Test
@@ -270,8 +270,8 @@ class OtPageRepositoryTest extends UnitTestCase
         $root_uid = 200;
         $root_page = $this->pageFixtures->getByUid($root_uid);
 
-        $this->pageRepository->getPage_noCheck($page_uid, true)->shouldBeCalled()->willReturn($page);
-        $this->pageRepository->getPage_noCheck($root_uid, true)->shouldBeCalled()->willReturn($root_page);
+        $this->pageRepository->getPage_noCheck($page_uid)->shouldBeCalled()->willReturn($page);
+        $this->pageRepository->getPage_noCheck($root_uid)->shouldBeCalled()->willReturn($root_page);
         $this->injectProphecies();
 
         $GLOBALS['_POST'] = ['id' => $page_uid];