refactoring test

tests/Service/Cotisation/UtilsTest.php

@@ -21,6 +21,22 @@ class UtilsTest extends TestCase
     private NetworkUtils $networkUtilsMock;
     private OrganizationUtils $organizationUtilsMock;
 
+    public function getOrganizationMock(): Organization{
+        $organizationMock = $this->getMockBuilder(Organization::class)->getMock();
+        return $organizationMock
+            ->method('getId')
+            ->willReturn(1);
+    }
+
+    public function getUtilsInstance(){
+        return new Utils(
+            $this->networkUtilsMock,
+            $this->organizationUtilsMock,
+            $this->networkOrganizationRepositoryMock,
+            $this->cotisationApiResourcesRepositoryMock
+        );
+    }
+
     public function setUp(): void
     {
         $this->networkOrganizationRepositoryMock =
@@ -51,10 +67,7 @@ class UtilsTest extends TestCase
      */
     public function testIsLastParentAndCMF(): void
     {
-        $organizationMock = $this->getMockBuilder(Organization::class)->getMock();
-        $organizationMock
-            ->method('getId')
-            ->willReturn(1);
+        $organizationMock = $this->getOrganizationMock();
 
         $this->networkOrganizationRepositoryMock
                 ->expects($this->once())
@@ -68,12 +81,7 @@ class UtilsTest extends TestCase
                 ->with($organizationMock)
                 ->willReturn(true);
 
-        $utils = new Utils(
-            $this->networkUtilsMock,
-            $this->organizationUtilsMock,
-            $this->networkOrganizationRepositoryMock,
-            $this->cotisationApiResourcesRepositoryMock
-        );
+        $utils = $this->getUtilsInstance();
         $this->assertTrue($utils->isLastParentAndCMF($organizationMock));
     }
 
@@ -82,10 +90,7 @@ class UtilsTest extends TestCase
      */
     public function testIsNotLastParentAndCMF(): void
     {
-        $organizationMock = $this->getMockBuilder(Organization::class)->getMock();
-        $organizationMock
-            ->method('getId')
-            ->willReturn(1);
+        $organizationMock = $this->getOrganizationMock();
 
         $this->networkOrganizationRepositoryMock
             ->expects($this->once())
@@ -97,12 +102,7 @@ class UtilsTest extends TestCase
             ->expects($this->never())
             ->method('isCMF');
 
-        $utils = new Utils(
-            $this->networkUtilsMock,
-            $this->organizationUtilsMock,
-            $this->networkOrganizationRepositoryMock,
-            $this->cotisationApiResourcesRepositoryMock
-        );
+        $utils = $this->getUtilsInstance();
         $this->assertFalse($utils->isLastParentAndCMF($organizationMock));
     }
 
@@ -125,12 +125,7 @@ class UtilsTest extends TestCase
             ->with($organizationMock)
             ->willReturn(true);
 
-        $utils = new Utils(
-            $this->networkUtilsMock,
-            $this->organizationUtilsMock,
-            $this->networkOrganizationRepositoryMock,
-            $this->cotisationApiResourcesRepositoryMock
-        );
+        $utils = $this->getUtilsInstance();
         $this->assertTrue($utils->isStructureAndCMF($organizationMock));
     }
 
@@ -151,12 +146,7 @@ class UtilsTest extends TestCase
             ->expects($this->never())
             ->method('isCMF');
 
-        $utils = new Utils(
-            $this->networkUtilsMock,
-            $this->organizationUtilsMock,
-            $this->networkOrganizationRepositoryMock,
-            $this->cotisationApiResourcesRepositoryMock
-        );
+        $utils = $this->getUtilsInstance();
         $this->assertFalse($utils->isStructureAndCMF($organizationMock));
     }
 
@@ -179,12 +169,7 @@ class UtilsTest extends TestCase
             ->with($organizationMock)
             ->willReturn(true);
 
-        $utils = new Utils(
-            $this->networkUtilsMock,
-            $this->organizationUtilsMock,
-            $this->networkOrganizationRepositoryMock,
-            $this->cotisationApiResourcesRepositoryMock
-        );
+        $utils = $this->getUtilsInstance();
         $this->assertTrue($utils->isManagerAndCMF($organizationMock));
     }
 
@@ -205,12 +190,7 @@ class UtilsTest extends TestCase
             ->expects($this->never())
             ->method('isCMF');
 
-        $utils = new Utils(
-            $this->networkUtilsMock,
-            $this->organizationUtilsMock,
-            $this->networkOrganizationRepositoryMock,
-            $this->cotisationApiResourcesRepositoryMock
-        );
+        $utils = $this->getUtilsInstance();
         $this->assertFalse($utils->isManagerAndCMF($organizationMock));
     }
 
@@ -219,10 +199,7 @@ class UtilsTest extends TestCase
      */
     public function testIsManagerAndNotLastParentAndCMF(): void
     {
-        $organizationMock = $this->getMockBuilder(Organization::class)->getMock();
-        $organizationMock
-            ->method('getId')
-            ->willReturn(1);
+        $organizationMock = $this->getOrganizationMock();
 
         $this->organizationUtilsMock
             ->expects($this->once())
@@ -240,12 +217,7 @@ class UtilsTest extends TestCase
             ->expects($this->never())
             ->method('isCMF');
 
-        $utils = new Utils(
-            $this->networkUtilsMock,
-            $this->organizationUtilsMock,
-            $this->networkOrganizationRepositoryMock,
-            $this->cotisationApiResourcesRepositoryMock
-        );
+        $utils = $this->getUtilsInstance();
         $this->assertTrue($utils->isManagerAndNotLastParentAndCMF($organizationMock));
     }
 
@@ -254,10 +226,7 @@ class UtilsTest extends TestCase
      */
     public function testIsManagerAndLastParentAndCMF(): void
     {
-        $organizationMock = $this->getMockBuilder(Organization::class)->getMock();
-        $organizationMock
-            ->method('getId')
-            ->willReturn(1);
+        $organizationMock = $this->getOrganizationMock();
 
         $this->organizationUtilsMock
             ->expects($this->once())
@@ -276,12 +245,7 @@ class UtilsTest extends TestCase
             ->method('isCMF')
             ->willReturn(true);
 
-        $utils = new Utils(
-            $this->networkUtilsMock,
-            $this->organizationUtilsMock,
-            $this->networkOrganizationRepositoryMock,
-            $this->cotisationApiResourcesRepositoryMock
-        );
+        $utils = $this->getUtilsInstance();
         $this->assertTrue($utils->isManagerAndLastParentAndCMF($organizationMock));
     }
 
@@ -292,17 +256,9 @@ class UtilsTest extends TestCase
     {
         $year = 2022;
 
-        $organizationMock = $this->getMockBuilder(Organization::class)->getMock();
-        $organizationMock
-            ->method('getId')
-            ->willReturn(1);
+        $organizationMock = $this->getOrganizationMock();
 
-        $utils = new Utils(
-            $this->networkUtilsMock,
-            $this->organizationUtilsMock,
-            $this->networkOrganizationRepositoryMock,
-            $this->cotisationApiResourcesRepositoryMock
-        );
+        $utils = $this->getUtilsInstance();
 
         $this->cotisationApiResourcesRepositoryMock
             ->method('getAffiliationState')
@@ -327,17 +283,9 @@ class UtilsTest extends TestCase
     {
         $year = 2022;
 
-        $organizationMock = $this->getMockBuilder(Organization::class)->getMock();
-        $organizationMock
-            ->method('getId')
-            ->willReturn(1);
+        $organizationMock = $this->getOrganizationMock();
 
-        $utils = new Utils(
-            $this->networkUtilsMock,
-            $this->organizationUtilsMock,
-            $this->networkOrganizationRepositoryMock,
-            $this->cotisationApiResourcesRepositoryMock
-        );
+        $utils = $this->getUtilsInstance();
 
         $this->cotisationApiResourcesRepositoryMock
             ->method('getAffiliationState')
@@ -354,17 +302,9 @@ class UtilsTest extends TestCase
     {
         $year = 2022;
 
-        $organizationMock = $this->getMockBuilder(Organization::class)->getMock();
-        $organizationMock
-            ->method('getId')
-            ->willReturn(1);
+        $organizationMock = $this->getOrganizationMock();
 
-        $utils = new Utils(
-            $this->networkUtilsMock,
-            $this->organizationUtilsMock,
-            $this->networkOrganizationRepositoryMock,
-            $this->cotisationApiResourcesRepositoryMock
-        );
+        $utils = $this->getUtilsInstance();
 
         $this->cotisationApiResourcesRepositoryMock
             ->method('isInsuranceNotDone')
@@ -381,17 +321,9 @@ class UtilsTest extends TestCase
     {
         $year = 2022;
 
-        $organizationMock = $this->getMockBuilder(Organization::class)->getMock();
-        $organizationMock
-            ->method('getId')
-            ->willReturn(1);
+        $organizationMock = $this->getOrganizationMock();
 
-        $utils = new Utils(
-            $this->networkUtilsMock,
-            $this->organizationUtilsMock,
-            $this->networkOrganizationRepositoryMock,
-            $this->cotisationApiResourcesRepositoryMock
-        );
+        $utils = $this->getUtilsInstance();
 
         $this->cotisationApiResourcesRepositoryMock
             ->method('isNotDGVCustomer')
@@ -406,12 +338,8 @@ class UtilsTest extends TestCase
      */
     public function testGetCurrentCotisationYear(): void
     {
-        $utils = new Utils(
-            $this->networkUtilsMock,
-            $this->organizationUtilsMock,
-            $this->networkOrganizationRepositoryMock,
-            $this->cotisationApiResourcesRepositoryMock
-        );
+        $utils = $this->getUtilsInstance();
+
         $today = new \DateTime('now');
         if($today->format('m') <= 9)
             $this->assertEquals($today->format('Y'), $utils->getCurrentCotisationYear());