minor evolutions

src/Commands/CronCommand.php

@@ -50,9 +50,11 @@ class CronCommand extends Command
     private LoggerInterface $logger;
     private CronjobIterator $cronjobIterator;
 
+    /** @noinspection PhpUnused */
     #[Required]
     /** @see https://symfony.com/doc/current/logging/channels_handlers.html#how-to-autowire-logger-channels */
     public function setLoggerInterface(LoggerInterface $cronLogger): void { $this->logger = $cronLogger; }
+    /** @noinspection PhpUnused */
     #[Required]
     public function setCronjobIterator(CronjobIterator $cronjobIterator): void { $this->cronjobIterator = $cronjobIterator; }
 
@@ -124,7 +126,7 @@ class CronCommand extends Command
             foreach (explode(',', $jobNames) as $name) {
                 try {
                     $jobs[] = $this->cronjobIterator->getByName($name);
-                } catch (\RuntimeException $e) {
+                } catch (RuntimeException $e) {
                     $this->output->writeln($e->getMessage());
                     $this->listJobs();
                     return Command::INVALID;

src/Service/Cron/BaseCronJob.php

@@ -15,7 +15,7 @@ use Symfony\Contracts\Service\Attribute\Required;
  * This class shouldn't implement directly the CronjobInterface because it shall not be injected itself into the
  * CronjobIterator, but all its subclasses should.
  */
-abstract class BaseCronJob
+abstract class BaseCronJob implements CronjobInterface
 {
     protected CronUIInterface $ui;
     protected LoggerInterface $logger;

src/Service/Cron/Job/CleanDb.php

@@ -16,7 +16,7 @@ use JetBrains\PhpStorm\Pure;
  *
  * >>> ot:cron clean-db
  */
-class CleanDb extends BaseCronJob implements CronjobInterface
+class CleanDb extends BaseCronJob
 {
     /**
      * Delay before deleting the record from the DB

src/Service/Cron/Job/CleanTempFiles.php

@@ -22,7 +22,7 @@ use JetBrains\PhpStorm\Pure;
  *
  * >>> ot:cron clean-temp-files
  */
-class CleanTempFiles extends BaseCronJob implements CronjobInterface
+class CleanTempFiles extends BaseCronJob
 {
     /**
      * Delay before removing a temporary file (in days)

src/Service/Cron/Job/DolibarrSync.php

@@ -12,16 +12,11 @@ use JetBrains\PhpStorm\Pure;
  *
  * >>> ot:cron dolibarr-sync
  */
-class DolibarrSync extends BaseCronJob implements CronjobInterface
+class DolibarrSync extends BaseCronJob
 {
-    /**
-     * How many operations are shown each time the preview choice is made
-     */
-    public const PREVIEW_CHUNK = 20;
-
     #[Pure]
     public function __construct(
-        private DolibarrSyncService $dolibarrSyncService
+        private readonly DolibarrSyncService $dolibarrSyncService
     ) {
         parent::__construct();
     }