Selaa lähdekoodia

fix unit tests

Olivier Massot 2 vuotta sitten
vanhempi
commit
b430da75b9
1 muutettua tiedostoa jossa 8 lisäystä ja 8 poistoa
  1. 8 8
      tests/Unit/Service/Cron/Job/CleanTempFilesTest.php

+ 8 - 8
tests/Unit/Service/Cron/Job/CleanTempFilesTest.php

@@ -23,8 +23,8 @@ use Psr\Log\LoggerInterface;
 use Symfony\Component\Config\Definition\Builder\ExprBuilder;
 
 class TestableCleanTempFile extends CleanTempFiles {
-    public function listFilesToDelete(\DateTime $maxDate): Collection { return parent::listFilesToDelete($maxDate); }
-    public function deleteFiles(Collection $files): void { parent::deleteFiles($files); }
+    public function listFilesToDelete(\DateTime $maxDate): array { return parent::listFilesToDelete($maxDate); }
+    public function deleteFiles(array $files): void { parent::deleteFiles($files); }
     public function purgeDb(\DateTime $maxDate, bool $commit = true): void { parent::purgeDb($maxDate, $commit); }
     public function purgeFiles(\DateTime $maxDate): int { return parent::purgeFiles($maxDate); }
     public function getQueryConditions(QueryBuilder $queryBuilder, \DateTime $maxDate): void { parent::getQueryConditions($queryBuilder, $maxDate); }
@@ -76,7 +76,7 @@ class CleanTempFilesTest extends TestCase
         $file3 = $this->getMockBuilder(File::class)->getMock();
         $file3->method('getPath')->willReturn('/foo/bar');
 
-        $cleanTempFiles->method('listFilesToDelete')->with($maxDate)->willReturn(new ArrayCollection([$file1, $file2, $file3]));
+        $cleanTempFiles->method('listFilesToDelete')->with($maxDate)->willReturn([$file1, $file2, $file3]);
 
         $this->ui->expects(self::atLeastOnce())->method('print')->withConsecutive(
             ["3 temporary files to be removed"],
@@ -98,11 +98,11 @@ class CleanTempFilesTest extends TestCase
 
         $cleanTempFiles = $this->getMockFor('execute');
 
-        $files = new ArrayCollection([
+        $files = [
             $this->getMockBuilder(File::class)->getMock(),
             $this->getMockBuilder(File::class)->getMock(),
             $this->getMockBuilder(File::class)->getMock()
-        ]);
+        ];
 
         $cleanTempFiles->method('listFilesToDelete')->willReturn($files)->with($maxDate);
 
@@ -140,9 +140,10 @@ class CleanTempFilesTest extends TestCase
         $query = $this->getMockBuilder(AbstractQuery::class)
             ->disableOriginalConstructor()
             ->getMock();
+
         $query->expects($this->once())
             ->method('getResult')
-            ->willReturn(new ArrayCollection());
+            ->willReturn([]);
 
         $queryBuilder->expects($this->once())
             ->method('getQuery')
@@ -152,8 +153,7 @@ class CleanTempFilesTest extends TestCase
         $result = $cleanTempFiles->listFilesToDelete($maxDate);
 
         // Vérifier que la méthode getResult() a été appelée sur la requête
-        $this->assertInstanceOf(Collection::class, $result);
-        $this->assertEquals(0, $result->count());
+        $this->assertEquals([], $result);
     }
 
     public function testPurgeDbCommitsTransactionIfCommitIsTrue(): void