Browse Source

disable yoda style in cs fixer

Olivier Massot 1 year ago
parent
commit
ad81dfbf35
75 changed files with 157 additions and 156 deletions
  1. 1 0
      .php-cs-fixer.dist.php
  2. 3 3
      src/Commands/CronCommand.php
  3. 1 1
      src/Doctrine/Access/AdditionalExtension/DateTimeConstraintExtensionAdditional.php
  4. 1 1
      src/Doctrine/Access/AdditionalExtension/StudentsExtensionAdditional.php
  5. 1 1
      src/Doctrine/Access/CurrentAccessExtension.php
  6. 1 1
      src/Doctrine/Access/CurrentUserPersonalizedListExtension.php
  7. 1 1
      src/Doctrine/Billing/CurrentResidenceAreaExtension.php
  8. 1 1
      src/Doctrine/Booking/AttendanceBookingReasonExtension.php
  9. 1 1
      src/Doctrine/Booking/CurrentCoursesExtension.php
  10. 1 1
      src/Doctrine/Core/AllowedAddressPostalExtension.php
  11. 1 1
      src/Doctrine/Core/CurrentUserNotificationExtension.php
  12. 1 1
      src/Doctrine/Core/CurrentUserNotificationUserExtension.php
  13. 1 1
      src/Doctrine/Education/CurrentCycleExtension.php
  14. 1 1
      src/Doctrine/Education/CurrentEducationNotationConfigExtension.php
  15. 1 1
      src/Doctrine/Education/CurrentEducationTimingExtension.php
  16. 1 1
      src/Doctrine/Network/CurrentNetworkOrganizationExtension.php
  17. 1 1
      src/Doctrine/Organization/CurrentOrganizationExtension.php
  18. 2 2
      src/Entity/Access/Access.php
  19. 1 1
      src/Entity/Core/AbstractInformation.php
  20. 1 1
      src/Entity/Education/EducationNotationConfig.php
  21. 1 1
      src/Entity/Network/NetworkOrganization.php
  22. 1 1
      src/Entity/Traits/ActivityPeriodTrait.php
  23. 1 1
      src/EventListener/OnKernelRequestPreRead.php
  24. 1 1
      src/EventSubscriber/ApiResourcesValidatorSubscriber.php
  25. 1 1
      src/Filter/ApiPlatform/Person/FullNameFilter.php
  26. 1 1
      src/Filter/ApiPlatform/Utils/ArrayFieldFilter.php
  27. 1 1
      src/Filter/ApiPlatform/Utils/DistanceFilter.php
  28. 3 3
      src/Filter/Doctrine/TimeConstraint/AbstractTimeFilter.php
  29. 1 1
      src/Repository/Access/AccessRepository.php
  30. 2 2
      src/Repository/Cotisation/CotisationApiResourcesRepository.php
  31. 6 6
      src/Security/Voter/EntityVoter/AbstractEntityVoter.php
  32. 1 1
      src/Security/Voter/EntityVoter/Core/BankAccountVoter.php
  33. 1 1
      src/Security/Voter/EntityVoter/Core/ContactPointVoter.php
  34. 4 4
      src/Security/Voter/EntityVoter/Core/FileVoter.php
  35. 1 1
      src/Security/Voter/InternalRequestsVoter.php
  36. 1 1
      src/Security/Voter/ModuleVoter.php
  37. 2 2
      src/Serializer/AccessContextBuilder.php
  38. 2 2
      src/Service/Access/Utils.php
  39. 3 3
      src/Service/ApiLegacy/ApiLegacyRequestService.php
  40. 3 3
      src/Service/ApiResourceBuilder/Dolibarr/DolibarrAccountBuilder.php
  41. 2 2
      src/Service/ApiResourceBuilder/Mobyt/MobytUserStatusBuilder.php
  42. 1 1
      src/Service/Constraint/AbstractTimeConstraintUtils.php
  43. 2 2
      src/Service/Core/ContactPointUtils.php
  44. 2 2
      src/Service/Cotisation/Utils.php
  45. 3 3
      src/Service/Doctrine/FiltersConfigurationService.php
  46. 6 6
      src/Service/Dolibarr/DolibarrApiService.php
  47. 24 24
      src/Service/Dolibarr/DolibarrSyncService.php
  48. 1 1
      src/Service/Education/EducationNotationUtils.php
  49. 4 4
      src/Service/Export/BaseExporter.php
  50. 3 3
      src/Service/Export/LicenceCmfExporter.php
  51. 1 1
      src/Service/File/Storage/ApiLegacyStorage.php
  52. 4 4
      src/Service/File/Storage/LocalStorage.php
  53. 3 3
      src/Service/Mailer/Mailer.php
  54. 2 2
      src/Service/OnChange/Organization/OnOrganizationChange.php
  55. 2 2
      src/Service/OnChange/Organization/OnParametersChange.php
  56. 3 3
      src/Service/OnlineRegistration/RegistrationStatusService.php
  57. 1 1
      src/Service/Organization/OrganizationProfileCreator.php
  58. 7 7
      src/Service/Organization/Utils.php
  59. 1 1
      src/Service/Rest/Operation/BaseRestOperation.php
  60. 2 2
      src/Service/Typo3/SubdomainService.php
  61. 3 3
      src/Service/Utils/ArrayUtils.php
  62. 1 1
      src/Service/Utils/DatesUtils.php
  63. 3 3
      src/Service/Utils/Path.php
  64. 1 1
      src/Service/Utils/Reflection.php
  65. 1 1
      src/Service/Utils/Siret.php
  66. 1 1
      src/Service/Utils/Uuid.php
  67. 1 1
      src/State/Provider/Core/DownloadProvider.php
  68. 1 1
      src/State/Provider/Core/ImageProvider.php
  69. 1 1
      src/State/Provider/OnlineRegistration/RegistrationAvailabilityProvider.php
  70. 1 1
      src/State/Provider/Organization/Subdomain/SubdomainAvailabilityProvider.php
  71. 2 2
      src/Validator/Core/ContactPointValidator.php
  72. 2 2
      src/Validator/Organization/OrganizationAddressPostalValidator.php
  73. 1 1
      tests/Application/OtWebTestCase.php
  74. 2 2
      tests/Unit/Security/Voter/EntityVoter/AbstractEntityVoterTest.php
  75. 2 2
      tests/Unit/Service/Utils/ArrayUtilsTest.php

+ 1 - 0
.php-cs-fixer.dist.php

@@ -19,6 +19,7 @@ $finder = (new PhpCsFixer\Finder())
 return (new PhpCsFixer\Config())
     ->setRules([
         '@Symfony' => true,
+        'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => false]
     ])
     ->setFinder($finder)
 ;

+ 3 - 3
src/Commands/CronCommand.php

@@ -114,17 +114,17 @@ class CronCommand extends Command
             return Command::INVALID;
         }
 
-        if (self::ACTION_LIST === $action) {
+        if ($action === self::ACTION_LIST) {
             $this->listJobs();
 
             return Command::SUCCESS;
         }
 
-        if (self::ACTION_RUN_ALL === $action) {
+        if ($action === self::ACTION_RUN_ALL) {
             $jobs = $this->cronjobIterator->getAll();
         }
 
-        if (self::ACTION_RUN === $action) {
+        if ($action === self::ACTION_RUN) {
             foreach (explode(',', $jobNames) as $name) {
                 try {
                     $jobs[] = $this->cronjobIterator->getByName($name);

+ 1 - 1
src/Doctrine/Access/AdditionalExtension/DateTimeConstraintExtensionAdditional.php

@@ -23,7 +23,7 @@ class DateTimeConstraintExtensionAdditional implements AdditionalAccessExtension
         return
 
                 $this->requestStack->getMainRequest()->isMethod('GET')
-                && true == $this->requestStack->getMainRequest()->get('_time_constraint', true)
+                && $this->requestStack->getMainRequest()->get('_time_constraint', true) == true
         ;
     }
 

+ 1 - 1
src/Doctrine/Access/AdditionalExtension/StudentsExtensionAdditional.php

@@ -13,7 +13,7 @@ class StudentsExtensionAdditional implements AdditionalAccessExtensionInterface
 {
     public function support(string $name): bool
     {
-        return 'cget_students' === $name;
+        return $name === 'cget_students';
     }
 
     public function addWhere(QueryBuilder $queryBuilder): void

+ 1 - 1
src/Doctrine/Access/CurrentAccessExtension.php

@@ -24,7 +24,7 @@ final class CurrentAccessExtension extends AbstractExtension
 
     public function supports(string $resourceClass, ?Operation $operation): bool
     {
-        return Access::class === $resourceClass;
+        return $resourceClass === Access::class;
     }
 
     public function addWhere(QueryBuilder $queryBuilder, string $resourceClass, ?Operation $operation): void

+ 1 - 1
src/Doctrine/Access/CurrentUserPersonalizedListExtension.php

@@ -21,7 +21,7 @@ final class CurrentUserPersonalizedListExtension extends AbstractExtension
 
     public function supports(string $resourceClass, ?Operation $operation): bool
     {
-        return PersonalizedList::class === $resourceClass;
+        return $resourceClass === PersonalizedList::class;
     }
 
     protected function addWhere(QueryBuilder $queryBuilder, string $resourceClass, ?Operation $operation): void

+ 1 - 1
src/Doctrine/Billing/CurrentResidenceAreaExtension.php

@@ -22,7 +22,7 @@ final class CurrentResidenceAreaExtension extends AbstractExtension
 
     public function supports(string $resourceClass, ?Operation $operation): bool
     {
-        return ResidenceArea::class === $resourceClass;
+        return $resourceClass === ResidenceArea::class;
     }
 
     protected function addWhere(QueryBuilder $queryBuilder, string $resourceClass, ?Operation $operation): void

+ 1 - 1
src/Doctrine/Booking/AttendanceBookingReasonExtension.php

@@ -22,7 +22,7 @@ final class AttendanceBookingReasonExtension extends AbstractExtension
 
     public function supports(string $resourceClass, ?Operation $operation): bool
     {
-        return AttendanceBookingReason::class === $resourceClass;
+        return $resourceClass === AttendanceBookingReason::class;
     }
 
     protected function addWhere(QueryBuilder $queryBuilder, string $resourceClass, ?Operation $operation): void

+ 1 - 1
src/Doctrine/Booking/CurrentCoursesExtension.php

@@ -22,7 +22,7 @@ final class CurrentCoursesExtension extends AbstractExtension
 
     public function supports(string $resourceClass, ?Operation $operation): bool
     {
-        return Course::class === $resourceClass;
+        return $resourceClass === Course::class;
     }
 
     /**

+ 1 - 1
src/Doctrine/Core/AllowedAddressPostalExtension.php

@@ -22,7 +22,7 @@ final class AllowedAddressPostalExtension extends AbstractExtension
 
     public function supports(string $resourceClass, ?Operation $operation): bool
     {
-        return AddressPostal::class === $resourceClass;
+        return $resourceClass === AddressPostal::class;
     }
 
     protected function addWhere(QueryBuilder $queryBuilder, string $resourceClass, ?Operation $operation): void

+ 1 - 1
src/Doctrine/Core/CurrentUserNotificationExtension.php

@@ -22,7 +22,7 @@ final class CurrentUserNotificationExtension extends AbstractExtension
 
     public function supports(string $resourceClass, ?Operation $operation): bool
     {
-        return Notification::class === $resourceClass;
+        return $resourceClass === Notification::class;
     }
 
     /**

+ 1 - 1
src/Doctrine/Core/CurrentUserNotificationUserExtension.php

@@ -22,7 +22,7 @@ final class CurrentUserNotificationUserExtension extends AbstractExtension
 
     public function supports(string $resourceClass, ?Operation $operation): bool
     {
-        return NotificationUser::class === $resourceClass;
+        return $resourceClass === NotificationUser::class;
     }
 
     /**

+ 1 - 1
src/Doctrine/Education/CurrentCycleExtension.php

@@ -22,7 +22,7 @@ final class CurrentCycleExtension extends AbstractExtension
 
     public function supports(string $resourceClass, ?Operation $operation): bool
     {
-        return Cycle::class === $resourceClass;
+        return $resourceClass === Cycle::class;
     }
 
     protected function addWhere(QueryBuilder $queryBuilder, string $resourceClass, ?Operation $operation): void

+ 1 - 1
src/Doctrine/Education/CurrentEducationNotationConfigExtension.php

@@ -22,7 +22,7 @@ final class CurrentEducationNotationConfigExtension extends AbstractExtension
 
     public function supports(string $resourceClass, ?Operation $operation): bool
     {
-        return EducationNotationConfig::class === $resourceClass;
+        return $resourceClass === EducationNotationConfig::class;
     }
 
     protected function addWhere(QueryBuilder $queryBuilder, string $resourceClass, ?Operation $operation): void

+ 1 - 1
src/Doctrine/Education/CurrentEducationTimingExtension.php

@@ -22,7 +22,7 @@ final class CurrentEducationTimingExtension extends AbstractExtension
 
     public function supports(string $resourceClass, ?Operation $operation): bool
     {
-        return EducationTiming::class === $resourceClass;
+        return $resourceClass === EducationTiming::class;
     }
 
     protected function addWhere(QueryBuilder $queryBuilder, string $resourceClass, ?Operation $operation): void

+ 1 - 1
src/Doctrine/Network/CurrentNetworkOrganizationExtension.php

@@ -22,7 +22,7 @@ final class CurrentNetworkOrganizationExtension extends AbstractExtension
 
     public function supports(string $resourceClass, ?Operation $operation): bool
     {
-        return NetworkOrganization::class === $resourceClass;
+        return $resourceClass === NetworkOrganization::class;
     }
 
     protected function addWhere(QueryBuilder $queryBuilder, string $resourceClass, ?Operation $operation): void

+ 1 - 1
src/Doctrine/Organization/CurrentOrganizationExtension.php

@@ -22,7 +22,7 @@ final class CurrentOrganizationExtension extends AbstractExtension
 
     public function supports(string $resourceClass, ?Operation $operation): bool
     {
-        return Organization::class === $resourceClass;
+        return $resourceClass === Organization::class;
     }
 
     protected function addWhere(QueryBuilder $queryBuilder, string $resourceClass, ?Operation $operation): void

+ 2 - 2
src/Entity/Access/Access.php

@@ -2127,11 +2127,11 @@ class Access implements UserInterface, PasswordAuthenticatedUserInterface
     public function setAccessBilling(?AccessBilling $accessBilling): self
     {
         // unset the owning side of the relation if necessary
-        if (null === $accessBilling && null !== $this->accessBilling) {
+        if ($accessBilling === null && $this->accessBilling !== null) {
             $this->accessBilling->setAccess(null);
         }
         // set the owning side of the relation if necessary
-        if (null !== $accessBilling && $accessBilling->getAccess() !== $this) {
+        if ($accessBilling !== null && $accessBilling->getAccess() !== $this) {
             $accessBilling->setAccess($this);
         }
         $this->accessBilling = $accessBilling;

+ 1 - 1
src/Entity/Core/AbstractInformation.php

@@ -189,7 +189,7 @@ class AbstractInformation
 
     public function setAvailabilityDate(?\DateTime $availabilityDate = null): self
     {
-        if (null == $availabilityDate) {
+        if ($availabilityDate == null) {
             $availabilityDate = new \DateTime();
         }
         $this->availabilityDate = $availabilityDate;

+ 1 - 1
src/Entity/Education/EducationNotationConfig.php

@@ -123,7 +123,7 @@ class EducationNotationConfig
 
     public function setCoefficient(?int $coefficient): self
     {
-        if (null === $coefficient) {
+        if ($coefficient === null) {
             $coefficient = 1;
         }
         $this->coefficient = $coefficient;

+ 1 - 1
src/Entity/Network/NetworkOrganization.php

@@ -113,7 +113,7 @@ class NetworkOrganization
 
     public function setStartDate(?\DateTime $startDate = null): self
     {
-        if (null == $startDate) {
+        if ($startDate == null) {
             $startDate = new \DateTime();
         }
         $this->startDate = $startDate;

+ 1 - 1
src/Entity/Traits/ActivityPeriodTrait.php

@@ -21,7 +21,7 @@ trait ActivityPeriodTrait
 
     public function setStartDate(?\DateTime $startDate = null): self
     {
-        if (null == $startDate) {
+        if ($startDate == null) {
             $startDate = new \DateTime();
         }
         $this->startDate = $startDate;

+ 1 - 1
src/EventListener/OnKernelRequestPreRead.php

@@ -51,7 +51,7 @@ class OnKernelRequestPreRead implements EventSubscriberInterface
             }
 
             $profileHash = $event->getRequest()->headers->get('profileHash');
-            if (null !== $profileHash) {
+            if ($profileHash !== null) {
                 $profileMask = [
                     'activityYear' => $access->getActivityYear(),
                     'historical' => $access->getHistorical(),

+ 1 - 1
src/EventSubscriber/ApiResourcesValidatorSubscriber.php

@@ -47,7 +47,7 @@ final class ApiResourcesValidatorSubscriber implements EventSubscriberInterface
 
         $violations = $this->validator->validate($entity);
 
-        if (0 !== count($violations)) {
+        if (count($violations) !== 0) {
             $messages = [];
             // there are errors, now you can show them
             foreach ($violations as $violation) {

+ 1 - 1
src/Filter/ApiPlatform/Person/FullNameFilter.php

@@ -22,7 +22,7 @@ class FullNameFilter extends AbstractFilter
         ?Operation $operation = null,
         array $context = []): void
     {
-        if ('fullname' !== $property) {
+        if ($property !== 'fullname') {
             return;
         }
         $alias = $queryBuilder->getRootAliases()[0];

+ 1 - 1
src/Filter/ApiPlatform/Utils/ArrayFieldFilter.php

@@ -41,7 +41,7 @@ class ArrayFieldFilter extends AbstractFilter
         $values = json_decode($value, true);
 
         // Si json_decode échoue ou si la valeur n'est pas un tableau, traiter comme une chaîne simple
-        if (JSON_ERROR_NONE !== json_last_error() || !is_array($values)) {
+        if (json_last_error() !== JSON_ERROR_NONE || !is_array($values)) {
             $values = [$value];
         }
 

+ 1 - 1
src/Filter/ApiPlatform/Utils/DistanceFilter.php

@@ -64,7 +64,7 @@ final class DistanceFilter extends AbstractFilter
         ?Operation $operation = null,
         array $context = []): void
     {
-        if ('withinDistance' !== $property) {
+        if ($property !== 'withinDistance') {
             return;
         }
         if (!preg_match('/^(-?\d+(\.\d+)?,){2}\d+(\.\d+)?$/', $value)) {

+ 3 - 3
src/Filter/Doctrine/TimeConstraint/AbstractTimeFilter.php

@@ -63,7 +63,7 @@ abstract class AbstractTimeFilter extends SQLFilter
      */
     protected function getStartAndEndFields(array $arguments): array
     {
-        if (null === static::$annotationStartField || null === static::$annotationEndField) {
+        if (static::$annotationStartField === null || static::$annotationEndField === null) {
             throw new \RuntimeException('Constraint annotation has not been properly configured');
         }
 
@@ -92,10 +92,10 @@ abstract class AbstractTimeFilter extends SQLFilter
      */
     public function addFilterConstraint(ClassMetadata $targetEntity, $targetTableAlias): string
     {
-        if (null === static::$constraintAnnotation) {
+        if (static::$constraintAnnotation === null) {
             throw new \RuntimeException('Constraint annotation has not been set');
         }
-        if (null === $this->accessId) {
+        if ($this->accessId === null) {
             throw new \RuntimeException('AccessId has not been set');
         }
 

+ 1 - 1
src/Repository/Access/AccessRepository.php

@@ -135,7 +135,7 @@ class AccessRepository extends ServiceEntityRepository implements UserLoaderInte
      */
     public function findByOrganizationAndMission(Organization $organization, FunctionEnum $function, ?\DateTime $date = null): array
     {
-        if (null === $date) {
+        if ($date === null) {
             $date = new \DateTime();
         }
 

+ 2 - 2
src/Repository/Cotisation/CotisationApiResourcesRepository.php

@@ -51,7 +51,7 @@ class CotisationApiResourcesRepository
         $query = $this->adminassosEntityManager->createNativeQuery($sql, $rsm);
         $result = $query->getOneOrNullResult();
 
-        return !empty($result) && 0 === $result['done'];
+        return !empty($result) && $result['done'] === 0;
     }
 
     /**
@@ -70,6 +70,6 @@ class CotisationApiResourcesRepository
         $query = $this->adminassosEntityManager->createNativeQuery($sql, $rsm);
         $result = $query->getOneOrNullResult();
 
-        return !empty($result) && 0 === $result['total'];
+        return !empty($result) && $result['total'] === 0;
     }
 }

+ 6 - 6
src/Security/Voter/EntityVoter/AbstractEntityVoter.php

@@ -63,11 +63,11 @@ abstract class AbstractEntityVoter extends Voter
      */
     protected function supports(string $attribute, mixed $subject): bool
     {
-        if (null === static::$entityClass) {
+        if (static::$entityClass === null) {
             throw new \RuntimeException('Setup the self::$entityClass property, or override the supports() method');
         }
 
-        return null !== $subject && $subject::class === static::$entityClass && in_array($attribute, static::$allowedOperations);
+        return $subject !== null && $subject::class === static::$entityClass && in_array($attribute, static::$allowedOperations);
     }
 
     /**
@@ -126,13 +126,13 @@ abstract class AbstractEntityVoter extends Voter
      */
     protected function getUser(): ?Access
     {
-        if (null === $this->user) {
+        if ($this->user === null) {
             /** @var Access $user */
             $user = $this->security->getUser();
 
             // <-- Special case of impersonated users: the switch user is not setup yet by symfony, we have to do it "manually"
             $switchHeaderId = $_SERVER['HTTP_X_SWITCH_USER'] ?? null;
-            if (null !== $switchHeaderId) {
+            if ($switchHeaderId !== null) {
                 $switchAs = $this->em->find(Access::class, $switchHeaderId);
                 if (
                     $switchAs
@@ -150,7 +150,7 @@ abstract class AbstractEntityVoter extends Voter
             $this->user = $user instanceof Access ? $user : false;
         }
 
-        return false !== $this->user ? $this->user : null;
+        return $this->user !== false ? $this->user : null;
     }
 
     /**
@@ -158,7 +158,7 @@ abstract class AbstractEntityVoter extends Voter
      */
     protected function isUserLoggedIn(): bool
     {
-        return null !== $this->getUser();
+        return $this->getUser() !== null;
     }
 
     /**

+ 1 - 1
src/Security/Voter/EntityVoter/Core/BankAccountVoter.php

@@ -26,7 +26,7 @@ class BankAccountVoter extends AbstractEntityVoter
     private function canInteractIfHasRole(object $subject, string $role): bool
     {
         return $this->isUserLoggedIn()
-            && 1 === $subject->getOrganization()->count()
+            && $subject->getOrganization()->count() === 1
             && $this->security->isGranted($role)
             && $subject->getOrganization()->current()->getId() === $this->getUser()->getOrganization()->getId();
     }

+ 1 - 1
src/Security/Voter/EntityVoter/Core/ContactPointVoter.php

@@ -24,7 +24,7 @@ class ContactPointVoter extends AbstractEntityVoter
     private function canInteractIfHasRole(object $subject, string $role): bool
     {
         return $this->isUserLoggedIn()
-            && 1 === $subject->getOrganization()->count()
+            && $subject->getOrganization()->count() === 1
             && $this->security->isGranted($role)
             && $subject->getOrganization()->current()->getId() === $this->getUser()->getOrganization()->getId();
     }

+ 4 - 4
src/Security/Voter/EntityVoter/Core/FileVoter.php

@@ -30,7 +30,7 @@ class FileVoter extends AbstractEntityVoter
         }
 
         // File has public visibility
-        if (FileVisibilityEnum::EVERYBODY === $subject->getVisibility()) {
+        if ($subject->getVisibility() === FileVisibilityEnum::EVERYBODY) {
             return true;
         }
 
@@ -142,7 +142,7 @@ class FileVoter extends AbstractEntityVoter
     protected function isInFileOwningGroupWithRole(File $file, Access $user): bool
     {
         $requiredRoles = $file->getAccessRoles();
-        if (0 === $requiredRoles->count()) {
+        if ($requiredRoles->count() === 0) {
             return false;
         }
 
@@ -166,12 +166,12 @@ class FileVoter extends AbstractEntityVoter
     {
         $today = DatesUtils::new();
 
-        if (null !== $file->getAvailabilityDate() && $file->getAvailabilityDate() > $today) {
+        if ($file->getAvailabilityDate() !== null && $file->getAvailabilityDate() > $today) {
             //  Cas particulier de la liste des factures
             // TODO: clarifier le ou les cas particulier(s) et les sortir de cette méthode (celle ci devrait tenir en deux lignes max)
             if (
                 $user
-                && FileTypeEnum::BILL === $file->getType()
+                && $file->getType() === FileTypeEnum::BILL
                 && $this->accessUtils->hasRole($user, 'ROLE_BILLACCOUNTING')
             ) {
                 return true;

+ 1 - 1
src/Security/Voter/InternalRequestsVoter.php

@@ -19,7 +19,7 @@ class InternalRequestsVoter extends Voter
 
     protected function supports(string $attribute, mixed $subject): bool
     {
-        return 'INTERNAL_REQUEST' === $attribute;
+        return $attribute === 'INTERNAL_REQUEST';
     }
 
     protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token): bool

+ 1 - 1
src/Security/Voter/ModuleVoter.php

@@ -49,7 +49,7 @@ class ModuleVoter extends Voter
         $module = $this->module->getModuleByResourceName($resourceMetadata->getOperation()->getShortName());
 
         // Check if there is a module for this entity : eq configuration problem
-        if (null === $module) {
+        if ($module === null) {
             throw new AccessDeniedHttpException(sprintf('There are no module for the entity (%s) !', $resourceMetadata->getOperation()->getShortName()));
         }
 

+ 2 - 2
src/Serializer/AccessContextBuilder.php

@@ -37,8 +37,8 @@ final class AccessContextBuilder implements SerializerContextBuilderInterface
         /** @var Access $access */
         $access = $this->security->getUser();
         if (
-            Access::class === $resourceClass
-            && false === $normalization
+            $resourceClass === Access::class
+            && $normalization === false
             && !$this->authorizationChecker->isGranted('ROLE_USERS')
             && (int) $request->get('id') === $access->getId()
         ) {

+ 2 - 2
src/Service/Access/Utils.php

@@ -94,14 +94,14 @@ class Utils
 
         foreach ($access->getOrganizationFunction() as $function) {
             if (
-                null !== $function->getStartDate()
+                $function->getStartDate() !== null
                 && DatesUtils::new() <= $function->getStartDate()->sub(new \DateInterval('PT23H59M'))
             ) {
                 // La fonction n'est pas encore active
                 continue;
             }
             if (
-                null !== $function->getEndDate()
+                $function->getEndDate() !== null
                 && DatesUtils::new() >= $function->getEndDate()->add(new \DateInterval('PT23H59M'))
             ) {
                 // La fonction n'est plus active

+ 3 - 3
src/Service/ApiLegacy/ApiLegacyRequestService.php

@@ -55,14 +55,14 @@ class ApiLegacyRequestService extends ApiRequestService
             /** @var Access|null $originalUser */
             $originalUser = $token->getOriginalToken()->getUser();
 
-            if (null === $originalUser) {
+            if ($originalUser === null) {
                 throw new HttpException(500, 'Request error : Switch original user missing');
             }
 
             $jwt = $this->jwtManager->create($originalUser->getPerson());
             $headers['x-accessid'] = $originalUser->getId();
             $headers['x-switch-access'] = $activeUser->getId();
-        } elseif (null !== $token && !($token instanceof NullToken) && null !== $token->getUser()) {
+        } elseif ($token !== null && !($token instanceof NullToken) && $token->getUser() !== null) {
             /** @var Access $activeUser */
             $activeUser = $token->getUser();
 
@@ -70,7 +70,7 @@ class ApiLegacyRequestService extends ApiRequestService
             $headers['x-accessid'] = $activeUser->getId();
         }
 
-        if (null !== $jwt) {
+        if ($jwt !== null) {
             $headers['authorization'] = 'BEARER '.$jwt;
         }
 

+ 3 - 3
src/Service/ApiResourceBuilder/Dolibarr/DolibarrAccountBuilder.php

@@ -31,14 +31,14 @@ class DolibarrAccountBuilder
         $accountData = $this->dolibarrApiService->getSociety($id);
         $dolibarrAccount = $this->createDolibarrAccount($id, $accountData);
 
-        if (null === $dolibarrAccount->getSocId()) {
+        if ($dolibarrAccount->getSocId() === null) {
             return $dolibarrAccount;
         }
 
         // Get active contract and services
         $contractData = $this->dolibarrApiService->getActiveContract($dolibarrAccount->getSocId());
 
-        if (null !== $contractData) {
+        if ($contractData !== null) {
             $contract = $this->createDolibarrContract($contractData);
             $dolibarrAccount->setContract($contract);
         }
@@ -60,7 +60,7 @@ class DolibarrAccountBuilder
     {
         $dolibarrAccount = new DolibarrAccount();
         $dolibarrAccount->setOrganizationId($organizationId);
-        if (null === $accountData) {
+        if ($accountData === null) {
             return $dolibarrAccount;
         }
 

+ 2 - 2
src/Service/ApiResourceBuilder/Mobyt/MobytUserStatusBuilder.php

@@ -25,7 +25,7 @@ class MobytUserStatusBuilder
         $userStatus->setOrganizationId($organizationId);
 
         $organization = $this->organizationRepository->find($organizationId);
-        if (null === $organization) {
+        if ($organization === null) {
             throw new \RuntimeException('Organization not found for user');
         }
         $parameters = $organization->getParameters();
@@ -42,7 +42,7 @@ class MobytUserStatusBuilder
         $topQualitySmsAmount = 0;
         foreach ($userStatusData['sms'] as $_ => $smsTypeData) {
             // we only retrieve the 'top quality sms', which are identified by the letter N in the mobyt api
-            if ('N' === $smsTypeData['type']) {
+            if ($smsTypeData['type'] === 'N') {
                 $topQualitySmsAmount = $smsTypeData['quantity'];
             }
         }

+ 1 - 1
src/Service/Constraint/AbstractTimeConstraintUtils.php

@@ -123,7 +123,7 @@ abstract class AbstractTimeConstraintUtils
      */
     protected function clearNull(array $constraints, string $key): array
     {
-        if (1 === count($constraints[$key]) && array_key_exists(self::NULL_VALUE, $constraints[$key])) {
+        if (count($constraints[$key]) === 1 && array_key_exists(self::NULL_VALUE, $constraints[$key])) {
             $constraints[$key] = [];
         }
 

+ 2 - 2
src/Service/Core/ContactPointUtils.php

@@ -31,11 +31,11 @@ class ContactPointUtils
             $access->getPerson()
         );
 
-        if (0 === count($contactPoints)) {
+        if (count($contactPoints) === 0) {
             return null;
         }
 
-        if (1 !== count($contactPoints)) {
+        if (count($contactPoints) !== 1) {
             throw new \RuntimeException('more_than_one_result');
         }
 

+ 2 - 2
src/Service/Cotisation/Utils.php

@@ -96,9 +96,9 @@ class Utils
 
         $alertState = null;
 
-        if (self::MEMBERSHIP_WAITING == $state || self::SUBMIT_IN_PROGRESS == $state) {
+        if ($state == self::MEMBERSHIP_WAITING || $state == self::SUBMIT_IN_PROGRESS) {
             $alertState = AlertStateEnum::AFFILIATION;
-        } elseif (self::MEMBERSHIP_NOPAYMENT == $state) {
+        } elseif ($state == self::MEMBERSHIP_NOPAYMENT) {
             $alertState = AlertStateEnum::INVOICE;
         } elseif ($this->cotisationApiResourcesRepository->isInsuranceNotDone($organization->getId(), $year)) {
             $alertState = AlertStateEnum::INSURANCE;

+ 3 - 3
src/Service/Doctrine/FiltersConfigurationService.php

@@ -63,7 +63,7 @@ class FiltersConfigurationService
      */
     public function suspendTimeConstraintFilters(): void
     {
-        if (null !== $this->previousTimeConstraintState) {
+        if ($this->previousTimeConstraintState !== null) {
             throw new \RuntimeException('date_time_filter is already suspended');
         }
 
@@ -78,7 +78,7 @@ class FiltersConfigurationService
         /** @var AbstractTimeFilter $filter */
         $filter = $filters->getFilter('date_time_filter');
 
-        $this->previousTimeConstraintState = false === $filter->isDisabled();
+        $this->previousTimeConstraintState = $filter->isDisabled() === false;
         $filter->setDisabled(true);
     }
 
@@ -90,7 +90,7 @@ class FiltersConfigurationService
      */
     public function restoreTimeConstraintFilters(): void
     {
-        if (null === $this->previousTimeConstraintState) {
+        if ($this->previousTimeConstraintState === null) {
             throw new \RuntimeException('date_time_filter has not been suspended, can not be restored');
         }
 

+ 6 - 6
src/Service/Dolibarr/DolibarrApiService.php

@@ -43,7 +43,7 @@ class DolibarrApiService extends ApiRequestService
                 ]
             )[0];
         } catch (HttpException $e) {
-            if (404 === $e->getStatusCode()) {
+            if ($e->getStatusCode() === 404) {
                 // /!\ The dolibarr API will return a 404 error if no results are found...
                 return null;
             }
@@ -64,7 +64,7 @@ class DolibarrApiService extends ApiRequestService
                 ['limit' => '1', 'sqlfilters' => 'statut:=:1', 'thirdparty_ids' => $socId]
             )[0];
         } catch (HttpException $e) {
-            if (404 === $e->getStatusCode()) {
+            if ($e->getStatusCode() === 404) {
                 // /!\ The dolibarr API will return a 404 error if no results are found...
                 return null;
             }
@@ -84,7 +84,7 @@ class DolibarrApiService extends ApiRequestService
                 'invoices',
                 ['sortfield' => 'datef', 'sortorder' => 'DESC', 'limit' => 5, 'sqlfilters' => 'fk_soc:=:'.$socId]);
         } catch (HttpException $e) {
-            if (404 === $e->getStatusCode()) {
+            if ($e->getStatusCode() === 404) {
                 // /!\ The dolibarr API will return a 404 error if no results are found...
                 return [];
             }
@@ -122,7 +122,7 @@ class DolibarrApiService extends ApiRequestService
                 ['limit' => 1000, 'thirdparty_ids' => $socId],
             );
         } catch (HttpException $e) {
-            if (404 === $e->getStatusCode()) {
+            if ($e->getStatusCode() === 404) {
                 // /!\ The dolibarr API will return a 404 error if no results are found...
                 return [];
             }
@@ -146,7 +146,7 @@ class DolibarrApiService extends ApiRequestService
                 'contacts?limit=1000&t.statut=1&thirdparty_ids='.$socId.'&sqlfilters:=:(te.2iopen_person_id%3A%3E%3A0)'
             );
         } catch (HttpException $e) {
-            if (404 === $e->getStatusCode()) {
+            if ($e->getStatusCode() === 404) {
                 // /!\ The dolibarr API will return a 404 error if no results are found...
                 return [];
             }
@@ -171,7 +171,7 @@ class DolibarrApiService extends ApiRequestService
                 $this->getJsonContent("/thirdparties/$socId/categories")
             );
         } catch (HttpException $e) {
-            if (404 === $e->getStatusCode()) {
+            if ($e->getStatusCode() === 404) {
                 // /!\ The dolibarr API will return a 404 error if no results are found...
                 return [];
             }

+ 24 - 24
src/Service/Dolibarr/DolibarrSyncService.php

@@ -128,10 +128,10 @@ class DolibarrSyncService
             $dolibarrSociety = $this->sanitizeDolibarrData($dolibarrSociety);
 
             $organization = $this->organizationRepository->find($organizationId);
-            if (null === $organization) {
+            if ($organization === null) {
                 $this->logger->error('Organization '.$organizationId.' not found in the Opentalent DB');
                 ++$i;
-                if (null !== $progressionCallback) {
+                if ($progressionCallback !== null) {
                     $progressionCallback($i, $total);
                 }
                 continue;
@@ -150,9 +150,9 @@ class DolibarrSyncService
 
             // Sync contact data of the client
             $mainAddress = $this->getOrganizationPostalAddress($organization);
-            if (null !== $mainAddress) {
+            if ($mainAddress !== null) {
                 $streetAddress = $this->addressPostalUtils->getFullStreetAddress($mainAddress);
-                if ('' !== trim($mainAddress->getAddressOwner() ?? '')) {
+                if (trim($mainAddress->getAddressOwner() ?? '') !== '') {
                     $streetAddress = $mainAddress->getAddressOwner()."\n".$streetAddress;
                 }
                 $newSocietyData['address'] = $streetAddress;
@@ -264,14 +264,14 @@ class DolibarrSyncService
                 ];
 
                 // The person's id may be missing if the contact is new or if it was found through its name
-                if (null !== $dolibarrContact && !(empty($dolibarrContact['array_options'] ?? []))) {
+                if ($dolibarrContact !== null && !(empty($dolibarrContact['array_options'] ?? []))) {
                     $newContactData['array_options'] = $dolibarrContact['array_options'];
                 } else {
                     $newContactData['array_options'] = [];
                 }
                 $newContactData['array_options']['options_2iopen_person_id'] = (string) $person->getId();
 
-                if (null === $dolibarrContact) {
+                if ($dolibarrContact === null) {
                     // New contact
                     $newContactData['socid'] = $dolibarrSocietyId;
 
@@ -308,7 +308,7 @@ class DolibarrSyncService
                     continue;
                 }
                 $personId = (int) $contactData['array_options']['options_2iopen_person_id'];
-                if (0 === (int) $contactData['statut']) {
+                if ((int) $contactData['statut'] === 0) {
                     // contact is already disabled
                     continue;
                 }
@@ -359,7 +359,7 @@ class DolibarrSyncService
 
             // Next society
             ++$i;
-            if (null !== $progressionCallback) {
+            if ($progressionCallback !== null) {
                 $progressionCallback($i, $total);
             }
         }
@@ -397,7 +397,7 @@ class DolibarrSyncService
                 // operation has already been treated
                 $this->logger->warning('Tried to execute an operation that was not marked as ready : '.$operation);
                 ++$i;
-                if (null !== $progressionCallback) {
+                if ($progressionCallback !== null) {
                     $progressionCallback($i, $total);
                 }
                 continue;
@@ -436,7 +436,7 @@ class DolibarrSyncService
             }
 
             ++$i;
-            if (null !== $progressionCallback) {
+            if ($progressionCallback !== null) {
                 $progressionCallback($i, $total);
             }
         }
@@ -550,8 +550,8 @@ class DolibarrSyncService
         foreach ($dolibarrContacts as $contactData) {
             if (
                 !($contactData['array_options']['options_2iopen_person_id'] ?? null)
-                && null !== $person->getName()
-                && null !== $person->getGivenName()
+                && $person->getName() !== null
+                && $person->getGivenName() !== null
                 && strtolower($person->getName()) === strtolower($contactData['lastname'] ?? '')
                 && strtolower($person->getGivenName()) === strtolower($contactData['firstname'] ?? '')
             ) {
@@ -575,14 +575,14 @@ class DolibarrSyncService
      */
     protected function sanitizeDolibarrData(?array $data): ?array
     {
-        if (null === $data) {
+        if ($data === null) {
             return null;
         }
 
         foreach ($data as $field => $value) {
             if (is_array($value)) {
                 $data[$field] = $this->sanitizeDolibarrData($value);
-            } elseif ('' === $value) {
+            } elseif ($value === '') {
                 $data[$field] = null;
             }
         }
@@ -633,10 +633,10 @@ class DolibarrSyncService
         foreach ($contactPriorities as $contactType) {
             foreach ($contactPoints as $contactPoint) {
                 if ($contactPoint->getContactType() === $contactType) {
-                    if (null !== $contactPoint->getTelphone()) {
+                    if ($contactPoint->getTelphone() !== null) {
                         return $this->formatPhoneNumber($contactPoint->getTelphone());
                     }
-                    if (null !== $contactPoint->getMobilPhone()) {
+                    if ($contactPoint->getMobilPhone() !== null) {
                         return $this->formatPhoneNumber($contactPoint->getMobilPhone());
                     }
                 }
@@ -662,7 +662,7 @@ class DolibarrSyncService
 
         foreach ($contactPriorities as $contactType) {
             foreach ($contactPoints as $contactPoint) {
-                if ($contactPoint->getContactType() === $contactType && null !== $contactPoint->getEmail()) {
+                if ($contactPoint->getContactType() === $contactType && $contactPoint->getEmail() !== null) {
                     return $contactPoint->getEmail();
                 }
             }
@@ -677,7 +677,7 @@ class DolibarrSyncService
     protected function getOrganizationNetworkId(Organization $organization): ?int
     {
         foreach ($organization->getNetworkOrganizations() as $networkOrganization) {
-            if (null !== $networkOrganization->getEndDate() && $networkOrganization->getEndDate() < new \DateTime()) {
+            if ($networkOrganization->getEndDate() !== null && $networkOrganization->getEndDate() < new \DateTime()) {
                 continue;
             }
 
@@ -792,20 +792,20 @@ class DolibarrSyncService
         $product = $organization->getSettings()->getProduct();
 
         // Association, school or school premium
-        if (LegalEnum::ASSOCIATION_LAW_1901 === $organization->getLegalStatus()) {
-            if (SettingsProductEnum::SCHOOL === $product) {
+        if ($organization->getLegalStatus() === LegalEnum::ASSOCIATION_LAW_1901) {
+            if ($product === SettingsProductEnum::SCHOOL) {
                 $expectedTags[] = self::ASSOCIATION_SCHOOL_TAG_ID;
             }
-            if (SettingsProductEnum::SCHOOL_PREMIUM === $product) {
+            if ($product === SettingsProductEnum::SCHOOL_PREMIUM) {
                 $expectedTags[] = self::ASSOCIATION_PREMIUM_TAG_ID;
             }
         }
         // Local authorities, school or school premium
-        if (LegalEnum::LOCAL_AUTHORITY === $organization->getLegalStatus()) {
-            if (SettingsProductEnum::SCHOOL === $product) {
+        if ($organization->getLegalStatus() === LegalEnum::LOCAL_AUTHORITY) {
+            if ($product === SettingsProductEnum::SCHOOL) {
                 $expectedTags[] = self::LOCAL_AUTH_SCHOOL_TAG_ID;
             }
-            if (SettingsProductEnum::SCHOOL_PREMIUM === $product) {
+            if ($product === SettingsProductEnum::SCHOOL_PREMIUM) {
                 $expectedTags[] = self::LOCAL_AUTH_PREMIUM_TAG_ID;
             }
         }

+ 1 - 1
src/Service/Education/EducationNotationUtils.php

@@ -52,7 +52,7 @@ class EducationNotationUtils
         if (
             is_null($educationNotation->getNote())
             || !$educationNotation->getCriteriaNotation()
-            || TypeCriteriaEnum::WITH_NOTATION !== $educationNotation->getCriteriaNotation()->getType()
+            || $educationNotation->getCriteriaNotation()->getType() !== TypeCriteriaEnum::WITH_NOTATION
         ) {
             return null;
         }

+ 4 - 4
src/Service/Export/BaseExporter.php

@@ -96,7 +96,7 @@ abstract class BaseExporter
     {
         $requesterId = $exportRequest->getRequesterId();
         $requester = $this->accessRepository->find($requesterId);
-        if (null === $requester) {
+        if ($requester === null) {
             throw new \RuntimeException('Unable to determine the user; abort.');
         }
 
@@ -110,13 +110,13 @@ abstract class BaseExporter
         $content = $this->encode($html, $exportRequest->getFormat()->value);
 
         // Met à jour ou créé l'enregistrement du fichier en base
-        if (null !== $exportRequest->getFileId()) {
+        if ($exportRequest->getFileId() !== null) {
             $file = $this->fileRepository->find($exportRequest->getFileId());
         } else {
             // Todo: voir si ce else est nécessaire une fois tous les exports implémentés (c'est
             //       juste au cas où le record File n'existe pas encore en base)
             $organization = $requester->getOrganization();
-            if (null === $organization) {
+            if ($organization === null) {
                 throw new \RuntimeException('Unable to determine the organization of the curent user; abort.');
             }
             $file = $this->prepareFile($exportRequest, false);
@@ -132,7 +132,7 @@ abstract class BaseExporter
     {
         $requesterId = $exportRequest->getRequesterId();
         $requester = $this->accessRepository->find($requesterId);
-        if (null === $requester) {
+        if ($requester === null) {
             throw new \RuntimeException('Unable to determine the current user; abort.');
         }
 

+ 3 - 3
src/Service/Export/LicenceCmfExporter.php

@@ -41,7 +41,7 @@ class LicenceCmfExporter extends BaseExporter implements ExporterInterface
     public function buildModel(ExportRequest $exportRequest): LicenceCmfCollection
     {
         $organization = $this->accessRepository->find($exportRequest->getRequesterId())?->getOrganization();
-        if (null === $organization) {
+        if ($organization === null) {
             throw new \RuntimeException('Unable to determine the organization of the curent user; abort.');
         }
 
@@ -53,7 +53,7 @@ class LicenceCmfExporter extends BaseExporter implements ExporterInterface
         $licenceCmf->setOrganizationIdentifier($organization->getIdentifier());
 
         $parentFederation = $organization->getNetworkOrganizations()->get(0)?->getParent();
-        if (null !== $parentFederation) {
+        if ($parentFederation !== null) {
             $licenceCmf->setFederationName($parentFederation->getName());
         }
 
@@ -69,7 +69,7 @@ class LicenceCmfExporter extends BaseExporter implements ExporterInterface
         $presidents = $this->accessRepository->findByOrganizationAndMission($organization, FunctionEnum::PRESIDENT);
         if (count($presidents) > 0) {
             $president = $presidents[0]->getPerson();
-            if (null !== $president) {
+            if ($president !== null) {
                 $licenceCmf->setPersonId($president->getId());
                 $licenceCmf->setPersonGender($president->getGender() ?? null);
                 $licenceCmf->setPersonFirstName($president->getGivenName());

+ 1 - 1
src/Service/File/Storage/ApiLegacyStorage.php

@@ -50,6 +50,6 @@ class ApiLegacyStorage implements FileStorageInterface
 
     public function support(File $file): bool
     {
-        return FileHostEnum::API1 === $file->getHost();
+        return $file->getHost() === FileHostEnum::API1;
     }
 }

+ 4 - 4
src/Service/File/Storage/LocalStorage.php

@@ -191,11 +191,11 @@ class LocalStorage implements FileStorageInterface
             throw new \RuntimeException('File has no filename');
         }
 
-        $isNewFile = null === $file->getSlug();
+        $isNewFile = $file->getSlug() === null;
         if ($isNewFile) {
             // Try to get the Access owner from the organization_id and person_id
             $access = null;
-            if (null !== $file->getOrganization() && null !== $file->getPerson()) {
+            if ($file->getOrganization() !== null && $file->getPerson() !== null) {
                 $access = $this->accessRepository->findOneBy(
                     ['organization' => $file->getOrganization(), 'person' => $file->getPerson()]
                 );
@@ -321,7 +321,7 @@ class LocalStorage implements FileStorageInterface
             $prefix = Path::join('temp', $prefix);
         }
 
-        if (null !== $type && FileTypeEnum::NONE !== $type) {
+        if ($type !== null && $type !== FileTypeEnum::NONE) {
             $prefix = Path::join($prefix, strtolower($type->value));
         }
 
@@ -349,6 +349,6 @@ class LocalStorage implements FileStorageInterface
 
     public function support(File $file): bool
     {
-        return FileHostEnum::AP2I === $file->getHost();
+        return $file->getHost() === FileHostEnum::AP2I;
     }
 }

+ 3 - 3
src/Service/Mailer/Mailer.php

@@ -210,9 +210,9 @@ class Mailer
             $emailRecipients = $email->getEmailRecipients();
             /** @var EmailRecipient $emailRecipient */
             foreach ($emailRecipients as $emailRecipient) {
-                if (ReportMessageStatusEnum::MISSING === $emailRecipient->getSendStatus()) {
+                if ($emailRecipient->getSendStatus() === ReportMessageStatusEnum::MISSING) {
                     $unDelivered[] = $emailRecipient;
-                } elseif (ReportMessageStatusEnum::DELIVERED === $emailRecipient->getSendStatus()) {
+                } elseif ($emailRecipient->getSendStatus() === ReportMessageStatusEnum::DELIVERED) {
                     $delivered[] = $emailRecipient;
                 }
             }
@@ -267,7 +267,7 @@ class Mailer
      */
     public function reduceEmailsCollectionInPreproduction(ArrayCollection $emailsCollection): ArrayCollection
     {
-        if ('prod' !== $this->environnement->get(EnvironnementVarEnum::APP_ENV->value) && $emailsCollection->count() > 20) {
+        if ($this->environnement->get(EnvironnementVarEnum::APP_ENV->value) !== 'prod' && $emailsCollection->count() > 20) {
             $startEmails = $emailsCollection->slice(0, 10);
             $endEmails = $emailsCollection->slice($emailsCollection->count() - 11, 10);
 

+ 2 - 2
src/Service/OnChange/Organization/OnOrganizationChange.php

@@ -29,11 +29,11 @@ class OnOrganizationChange extends OnChangeDefault
      */
     public function onLegalStatusChange(Organization $organization): void
     {
-        if (LegalEnum::ASSOCIATION_LAW_1901 !== $organization->getLegalStatus()) {
+        if ($organization->getLegalStatus() !== LegalEnum::ASSOCIATION_LAW_1901) {
             $organization->getParameters()->setShowAdherentList(false);
         }
 
-        if (LegalEnum::COMMERCIAL_SOCIETY === $organization->getLegalStatus()) {
+        if ($organization->getLegalStatus() === LegalEnum::COMMERCIAL_SOCIETY) {
             $organization->getBillingSetting()->setApplyVat(true);
         }
     }

+ 2 - 2
src/Service/OnChange/Organization/OnParametersChange.php

@@ -36,7 +36,7 @@ class OnParametersChange extends OnChangeDefault
     {
         // Une structure CMF n'a pas le droit de désactiver son site typo3
         if (
-            true === $parameters->getDesactivateOpentalentSiteWeb()
+            $parameters->getDesactivateOpentalentSiteWeb() === true
             && $this->networkUtils->isCMFAndActiveNow($parameters->getOrganization())
         ) {
             throw new \RuntimeException('This structure is currently active in the CMF network, the website can not be disabled.');
@@ -120,7 +120,7 @@ class OnParametersChange extends OnChangeDefault
     {
         foreach ($parameters->getOrganization()->getEducationNotationConfigs() as $educationNotationConfig) {
             /* @var EducationNotationConfig $educationNotationConfig */
-            if (AdvancedEducationNotationTypeEnum::BY_TEACHER === $parameters->getAdvancedEducationNotationType()) {
+            if ($parameters->getAdvancedEducationNotationType() === AdvancedEducationNotationTypeEnum::BY_TEACHER) {
                 foreach ($educationNotationConfig->getEducationCurriculums() as $educationCurriculum) {
                     $educationCurriculum->setEducationNotationConfig(null);
                 }

+ 3 - 3
src/Service/OnlineRegistration/RegistrationStatusService.php

@@ -31,7 +31,7 @@ class RegistrationStatusService
     public function getStatus(Access $access): ?RegistrationStatusEnum
     {
         $currentAccessWish = $this->onlineRegistrationService->getCurrentAccessWish($access);
-        if (null === $currentAccessWish) {
+        if ($currentAccessWish === null) {
             // TODO: est-ce qu'il ne faudrait pas plutôt lever une erreur ici plutôt que de retourner null?
             return null;
         }
@@ -42,7 +42,7 @@ class RegistrationStatusService
         }
 
         $wishesCountByStatus = $this->countEducationsByRegistrationStatus($currentAccessWish);
-        if (null === $wishesCountByStatus) {
+        if ($wishesCountByStatus === null) {
             // TODO: est-ce qu'il ne faudrait pas plutôt lever une erreur ici plutôt que de retourner null?
             return null;
         }
@@ -111,7 +111,7 @@ class RegistrationStatusService
         ];
 
         foreach ($reregistrationWishes as $reregistrationWish) {
-            if (WishRegistrationEnum::REREGISTER !== $reregistrationWish->getWishRegistration()) {
+            if ($reregistrationWish->getWishRegistration() !== WishRegistrationEnum::REREGISTER) {
                 continue;
             }
             ++$registrationStatuses[$reregistrationWish->getRegistrationStatus()];

+ 1 - 1
src/Service/Organization/OrganizationProfileCreator.php

@@ -39,7 +39,7 @@ class OrganizationProfileCreator
         $organizationProfile->setHasChildren($organization->getNetworkOrganizationChildren()->count() > 1);
         $organizationProfile->setShowAdherentList(
             $organization->getParameters()->getShowAdherentList()
-            && PrincipalTypeEnum::ARTISTIC_EDUCATION_ONLY !== $organization->getPrincipalType()
+            && $organization->getPrincipalType() !== PrincipalTypeEnum::ARTISTIC_EDUCATION_ONLY
         );
 
         foreach ($organization->getNetworkOrganizations() as $networkOrganization) {

+ 7 - 7
src/Service/Organization/Utils.php

@@ -26,8 +26,8 @@ class Utils
      */
     public function isStructure(Organization $organization): bool
     {
-        return SettingsProductEnum::MANAGER !== $organization->getSettings()->getProduct()
-               && SettingsProductEnum::MANAGER_PREMIUM !== $organization->getSettings()->getProduct();
+        return $organization->getSettings()->getProduct() !== SettingsProductEnum::MANAGER
+               && $organization->getSettings()->getProduct() !== SettingsProductEnum::MANAGER_PREMIUM;
     }
 
     /**
@@ -37,7 +37,7 @@ class Utils
      */
     public function isManager(Organization $organization): bool
     {
-        return SettingsProductEnum::MANAGER === $organization->getSettings()->getProduct();
+        return $organization->getSettings()->getProduct() === SettingsProductEnum::MANAGER;
     }
 
     /**
@@ -47,8 +47,8 @@ class Utils
      */
     public function isSchool(Organization $organization): bool
     {
-        return SettingsProductEnum::SCHOOL === $organization->getSettings()->getProduct()
-            || SettingsProductEnum::SCHOOL_PREMIUM === $organization->getSettings()->getProduct();
+        return $organization->getSettings()->getProduct() === SettingsProductEnum::SCHOOL
+            || $organization->getSettings()->getProduct() === SettingsProductEnum::SCHOOL_PREMIUM;
     }
 
     /**
@@ -58,8 +58,8 @@ class Utils
      */
     public function isArtist(Organization $organization): bool
     {
-        return SettingsProductEnum::ARTIST === $organization->getSettings()->getProduct()
-            || SettingsProductEnum::ARTIST_PREMIUM === $organization->getSettings()->getProduct();
+        return $organization->getSettings()->getProduct() === SettingsProductEnum::ARTIST
+            || $organization->getSettings()->getProduct() === SettingsProductEnum::ARTIST_PREMIUM;
     }
 
     /**

+ 1 - 1
src/Service/Rest/Operation/BaseRestOperation.php

@@ -52,7 +52,7 @@ abstract class BaseRestOperation
         try {
             $response = $apiService->request($this->method, $this->path, $this->parameters, $this->options);
 
-            if (200 === $response->getStatusCode()) {
+            if ($response->getStatusCode() === 200) {
                 $this->status = self::STATUS_DONE;
             } else {
                 $this->status = self::STATUS_ERROR;

+ 2 - 2
src/Service/Typo3/SubdomainService.php

@@ -73,7 +73,7 @@ class SubdomainService
 
         $regex = '/^'.strtolower(implode('|', $subRegexes)).'$/';
 
-        return 0 !== preg_match($regex, $subdomainValue);
+        return preg_match($regex, $subdomainValue) !== 0;
     }
 
     /**
@@ -81,7 +81,7 @@ class SubdomainService
      */
     public function isRegistered(string $subdomainValue): bool
     {
-        return 0 !== count($this->subdomainRepository->findBy(['subdomain' => $subdomainValue]));
+        return count($this->subdomainRepository->findBy(['subdomain' => $subdomainValue])) !== 0;
     }
 
     /**

+ 3 - 3
src/Service/Utils/ArrayUtils.php

@@ -63,9 +63,9 @@ class ArrayUtils
                 if (!empty($newVal)) {
                     $changes[$field] = $newVal;
                 }
-            } elseif (null === $callback && $value !== $initialArray[$field]) {
+            } elseif ($callback === null && $value !== $initialArray[$field]) {
                 $changes[$field] = $value;
-            } elseif (null !== $callback && !$callback($value, $initialArray[$field])) {
+            } elseif ($callback !== null && !$callback($value, $initialArray[$field])) {
                 $changes[$field] = $value;
             }
         }
@@ -90,7 +90,7 @@ class ArrayUtils
     public static function getAndCast(array $array, mixed $key, string $type): mixed
     {
         $value = $array[$key] ?? null;
-        if (null !== $value) {
+        if ($value !== null) {
             settype($value, $type);
         }
 

+ 1 - 1
src/Service/Utils/DatesUtils.php

@@ -19,7 +19,7 @@ class DatesUtils
      */
     public static function new(string $datetime = 'now', ?\DateTimeZone $timezone = null): \DateTime
     {
-        if ('now' === $datetime) {
+        if ($datetime === 'now') {
             $datetime = static::$fakeDateTime ?? $datetime;
         }
 

+ 3 - 3
src/Service/Utils/Path.php

@@ -43,7 +43,7 @@ class Path
     public static function join(string|int ...$paths): string
     {
         $paths = array_map(function ($x) { return ''.$x; }, $paths);
-        $paths = array_filter($paths, static function ($s) { return '' !== $s; });
+        $paths = array_filter($paths, static function ($s) { return $s !== ''; });
 
         return preg_replace('#/+#', '/', implode('/', $paths));
     }
@@ -70,7 +70,7 @@ class Path
     public static function read(string $path): string
     {
         $content = file_get_contents($path);
-        if (false === $content) {
+        if ($content === false) {
             throw new \RuntimeException('File could not be read');
         }
 
@@ -107,7 +107,7 @@ class Path
         }
 
         foreach (scandir($path) as $item) {
-            if ('.' == $item || '..' == $item) {
+            if ($item == '.' || $item == '..') {
                 continue;
             }
 

+ 1 - 1
src/Service/Utils/Reflection.php

@@ -23,7 +23,7 @@ class Reflection
     public function dynamicInvokeServiceWithArgsAndMethod(string $serviceName, string $method, array $parameters = []): mixed
     {
         $class = $this->container->get($serviceName);
-        if (null === $class) {
+        if ($class === null) {
             throw new \LogicException('no class found for service '.$serviceName, 400);
         }
         if (!method_exists($class, $method)) {

+ 1 - 1
src/Service/Utils/Siret.php

@@ -34,6 +34,6 @@ class Siret
     {
         $response = $this->clientSiret->request('GET', $siret);
 
-        return Response::HTTP_OK === $response->getStatusCode();
+        return $response->getStatusCode() === Response::HTTP_OK;
     }
 }

+ 1 - 1
src/Service/Utils/Uuid.php

@@ -16,6 +16,6 @@ class Uuid
     {
         $uuid = \Ramsey\Uuid\Uuid::uuid4()->toString();
 
-        return null !== $length ? substr($uuid, 0, $length) : $uuid;
+        return $length !== null ? substr($uuid, 0, $length) : $uuid;
     }
 }

+ 1 - 1
src/State/Provider/Core/DownloadProvider.php

@@ -51,7 +51,7 @@ final class DownloadProvider implements ProviderInterface
         if (empty($file)) {
             throw new \RuntimeException('File '.$fileId.' does not exist; abort.');
         }
-        if (FileStatusEnum::READY !== $file->getStatus()) {
+        if ($file->getStatus() !== FileStatusEnum::READY) {
             throw new \RuntimeException('File '.$fileId.' has '.$file->getStatus().' status; abort.');
         }
 

+ 1 - 1
src/State/Provider/Core/ImageProvider.php

@@ -52,7 +52,7 @@ final class ImageProvider implements ProviderInterface
         if (empty($file)) {
             throw new \RuntimeException('Image '.$fileId.' does not exist; abort.');
         }
-        if (FileStatusEnum::READY !== $file->getStatus()) {
+        if ($file->getStatus() !== FileStatusEnum::READY) {
             throw new \RuntimeException('Image '.$fileId.' has '.$file->getStatus().' status; abort.');
         }
         if (!$this->fileUtils->isImage($file)) {

+ 1 - 1
src/State/Provider/OnlineRegistration/RegistrationAvailabilityProvider.php

@@ -40,7 +40,7 @@ class RegistrationAvailabilityProvider implements ProviderInterface
 
         $availability = new RegistrationAvailability();
         $availability->setAccessId($currentAccess->getId());
-        $availability->setAvailable(200 === $response->getStatusCode());
+        $availability->setAvailable($response->getStatusCode() === 200);
         $availability->setMessage($content['message']);
 
         return $availability;

+ 1 - 1
src/State/Provider/Organization/Subdomain/SubdomainAvailabilityProvider.php

@@ -34,7 +34,7 @@ final class SubdomainAvailabilityProvider implements ProviderInterface
 
         $filters = $context['filters'] ?? [];
         $subdomain = $filters['subdomain'] ?? null;
-        if (null === $subdomain) {
+        if ($subdomain === null) {
             throw new \RuntimeException('missing parameter: subdomain', Response::HTTP_BAD_REQUEST);
         }
 

+ 2 - 2
src/Validator/Core/ContactPointValidator.php

@@ -25,7 +25,7 @@ class ContactPointValidator extends ConstraintValidator
         $contactPoint = $value;
 
         // si le type est autre, on valide
-        if (ContactPointTypeEnum::OTHER === $contactPoint->getContactType()) {
+        if ($contactPoint->getContactType() === ContactPointTypeEnum::OTHER) {
             return true;
         }
 
@@ -37,7 +37,7 @@ class ContactPointValidator extends ConstraintValidator
         }
 
         // Si le nombre de point de contact du type est supérieur à 1, OU si le nombre est égale a 1 ET que l'id du point de contact n'est pas celui en cours : invalide.
-        if (count($contactPointByType) > 1 || (1 === count($contactPointByType) && $contactPointByType[0]->getId() !== $contactPoint->getId())) {
+        if (count($contactPointByType) > 1 || (count($contactPointByType) === 1 && $contactPointByType[0]->getId() !== $contactPoint->getId())) {
             $this->context->buildViolation($constraint->payload)
                 ->setParameter('{{ type }}', $contactPoint->getContactType()->value)
                 ->atPath('contactType')

+ 2 - 2
src/Validator/Organization/OrganizationAddressPostalValidator.php

@@ -25,13 +25,13 @@ class OrganizationAddressPostalValidator extends ConstraintValidator
         $organizationAddressPostal = $value;
 
         // si le type est adresse autre, on valide
-        if (AddressPostalOrganizationTypeEnum::ADDRESS_OTHER === $organizationAddressPostal->getType()) {
+        if ($organizationAddressPostal->getType() === AddressPostalOrganizationTypeEnum::ADDRESS_OTHER) {
             return true;
         }
 
         $addressesByType = $this->organizationAddressPostalRepository->getByType($organizationAddressPostal->getType(), $organizationAddressPostal->getOrganization());
         // Si le nombre d'adress du type est supérieur à 1, OU si le nombre est égale a 1 ET que l'id de l'adresse n'est pas celui en cours : invalide.
-        if (count($addressesByType) > 1 || (1 === count($addressesByType) && $addressesByType[0]->getId() !== $organizationAddressPostal->getId())) {
+        if (count($addressesByType) > 1 || (count($addressesByType) === 1 && $addressesByType[0]->getId() !== $organizationAddressPostal->getId())) {
             $this->context->buildViolation($constraint->payload)
                 ->setParameter('{{ type }}', $organizationAddressPostal->getType()->value)
                 ->atPath('type')

+ 1 - 1
tests/Application/OtWebTestCase.php

@@ -222,7 +222,7 @@ abstract class OtWebTestCase extends ApiTestCase
     {
         $this->assertResponseStatusCodeSame($expectedStatus);
 
-        if (200 == $expectedStatus) {
+        if ($expectedStatus == 200) {
             $this->assertResponseIsSuccessful();
         }
 

+ 2 - 2
tests/Unit/Security/Voter/EntityVoter/AbstractEntityVoterTest.php

@@ -122,7 +122,7 @@ class AbstractVoterTest extends TestCase
         TestableAbstractEntityVoter::setAllowedOperations($this->initialAllowedOperations);
 
         // Reinitialize the global variables
-        if (null !== $this->initialSwitchHeader) {
+        if ($this->initialSwitchHeader !== null) {
             $_SERVER['HTTP_X_SWITCH_USER'] = $this->initialSwitchHeader;
         } elseif (array_key_exists('HTTP_X_SWITCH_USER', $_SERVER)) {
             unset($_SERVER['HTTP_X_SWITCH_USER']);
@@ -130,7 +130,7 @@ class AbstractVoterTest extends TestCase
 
         $_SERVER['REMOTE_ADDR'] = $this->initialRemoteAddr;
 
-        if (null !== $this->initialSwitchHeader) {
+        if ($this->initialSwitchHeader !== null) {
             $_SERVER['HTTP_INTERNAL_REQUESTS_TOKEN'] = $this->initialSwitchHeader;
         } elseif (array_key_exists('HTTP_INTERNAL_REQUESTS_TOKEN', $_SERVER)) {
             unset($_SERVER['HTTP_INTERNAL_REQUESTS_TOKEN']);

+ 2 - 2
tests/Unit/Service/Utils/ArrayUtilsTest.php

@@ -9,7 +9,7 @@ class ArrayUtilsTest extends TestCase
 {
     public function testAll(): void
     {
-        $isEven = function ($num) { return 0 === $num % 2; };
+        $isEven = function ($num) { return $num % 2 === 0; };
 
         $this->assertFalse(
             ArrayUtils::all([1, 2, 3], $isEven)
@@ -22,7 +22,7 @@ class ArrayUtilsTest extends TestCase
 
     public function testAny(): void
     {
-        $isEven = function ($num) { return 0 === $num % 2; };
+        $isEven = function ($num) { return $num % 2 === 0; };
 
         $this->assertFalse(
             ArrayUtils::any([1, 3, 5], $isEven)