Merge branch 'feature/V8-4346-tests-applicatifs--poc-avec-lent' into develop

composer.json

@@ -87,7 +87,7 @@
     "symfony/browser-kit": "6.2.*",
     "symfony/css-selector": "6.2.*",
     "symfony/debug-bundle": "6.2.*",
-    "symfony/maker-bundle": "^1.21",
+    "symfony/maker-bundle": "^1.48",
     "symfony/phpunit-bridge": "^6.2",
     "symfony/stopwatch": "6.2.*",
     "symfony/web-profiler-bundle": "6.2.*",

config/opentalent/products.yaml

@@ -57,6 +57,7 @@ opentalent:
           - PersonActivity
           - PersonHoliday
           - OrganizationResponsability
+          - Person
         roles:
           - ROLE_USERS
           - ROLE_ACCOUNTS

config/packages/staging/security.yaml

@@ -3,6 +3,4 @@
 security:
   password_hashers:
     App\Entity\Person\Person:
-      algorithm: md5
-      encode_as_base64: false
-      iterations: 0
+      algorithm: plaintext

src/Entity/Person/Person.php

@@ -45,8 +45,9 @@ class Person implements UserInterface, PasswordAuthenticatedUserInterface
     #[ORM\Column(length: 180, unique: true, nullable: true)]
     private ?string $username = null;
 
-    /** @var string[]  */
-    private array $roles = [];
+    /** @var string[]|null  */
+    #[ORM\Column(type: 'json', nullable: true)]
+    private ?array $roles = [];
 
     #[ORM\Column(nullable: true)]
     private ?string $password = null;

tests/Application/OtWebTestCase.php

@@ -2,33 +2,134 @@
 
 namespace App\Tests\Application;
 
+use App\Entity\Access\Access;
+use App\Entity\Person\Person;
 use App\Entity\Public\FederationStructure;
+use App\Enum\Organization\LegalEnum;
+use App\Enum\Organization\PrincipalTypeEnum;
+use App\Enum\Organization\SettingsProductEnum;
+use App\Tests\Fixture\Factory\Access\AccessFactory;
+use App\Tests\Fixture\Factory\Organization\OrganizationFactory;
+use App\Tests\Fixture\Factory\Organization\SettingsFactory;
+use App\Tests\Fixture\Factory\Person\PersonFactory;
+use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\Common\DataFixtures\Purger\ORMPurger;
+use Symfony\Bundle\SecurityBundle\Security;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\DomCrawler\Crawler;
 use ApiPlatform\Symfony\Bundle\Test\Client;
 use ApiPlatform\Symfony\Bundle\Test\ApiTestCase;
 use Symfony\Contracts\HttpClient\ResponseInterface;
+use Zenstruck\Foundry\Proxy;
 
 /**
  * Base class for applicative tests
  */
 abstract class OtWebTestCase extends ApiTestCase
 {
+    protected EntityManagerInterface $em;
     protected Client $client;
+    protected Access | Proxy | null $user = null;
+    protected ?string $securityToken = null;
 
+    /**
+     * Executed before each test
+     *
+     * @return void
+     * @throws \Exception
+     */
     public function setup(): void {
+
+        // Boot le kernel symfony et récupère l'entity manager
+        // @see https://symfony.com/doc/current/testing.html#retrieving-services-in-the-test
+        self::bootKernel();
+        $this->em = static::getContainer()->get(EntityManagerInterface::class);
+
+        // Purge DB before populating new fixtures
+        $this->purgeDb();
+
+        // Définit les fixtures et flush
+        $this->loadFixture();
+        $this->em->flush();
+
+        // Instancie le client qui exécutera les requêtes à l'api
+        // @see https://symfony.com/doc/current/testing.html#making-requests
         $this->client = static::createClient();
     }
 
+    /**
+     * Delete all DB records before populating fixtures.
+     *
+     * @return void
+     * @throws \Doctrine\DBAL\Exception
+     */
+    private function purgeDb() {
+        if (!preg_match('/.*test.*/', $this->em->getConnection()->getDatabase())) {
+            throw new \RuntimeException("The DB name shall contain 'test' in its name to be purge");
+        }
+
+        $this->em->getConnection()->exec('SET FOREIGN_KEY_CHECKS = 0;');
+        $purger = new ORMPurger($this->em);
+        $purger->setPurgeMode(ORMPurger::PURGE_MODE_DELETE);
+        $purger->purge();
+        $this->em->getConnection()->exec('SET FOREIGN_KEY_CHECKS = 1;');
+    }
+
+    /**
+     * Create and persist the fixtures (do not flush)
+     *
+     * @see https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html#same-entities-used-in-these-docs
+     *
+     * @return void
+     */
+    protected function loadFixture(): void {
+        $person = PersonFactory::createOne(
+            [
+                'username' => 'username',
+                'password' => 'password'
+            ]
+        );
+
+        $organization = OrganizationFactory::createOne([
+            'legalStatus' => LegalEnum::ASSOCIATION_LAW_1901()->getValue(),
+            'principalType' => PrincipalTypeEnum::ARTISTIC_EDUCATION_ONLY()->getValue(),
+            'name' => 'My Organization'
+        ]);
+
+        SettingsFactory::createOne([
+            'product' => SettingsProductEnum::ARTIST(),
+            'organization' => $organization
+        ]);
+
+        $this->user = AccessFactory::createOne([
+            'person' => $person,
+            'organization' => $organization,
+            'roles' => ['ROLE_USERS_VIEW']
+        ]);
+    }
+
     /**
      * Send a requests, parse the hydra response and return an object or a Collection
      *
      * @param string $method
      * @param string $route
-     * @param array<mixed> $parameters
+     * @param array<mixed> $data
+     * @param array<mixed> $headers
      * @return ResponseInterface
      */
-    protected function request(string $method, string $route, array $parameters = []): ResponseInterface {
+    protected function request(string $method, string $route, array | null $data = null, array $headers = []): ResponseInterface {
+        if ($this->user) {
+            $headers = array_merge(
+                ['x-accessid' => $this->user->getId(), 'authorization' => 'BEARER ' . $this->securityToken],
+                $headers
+            );
+        }
+
+        $parameters = ['headers' => $headers];
+        if ($data) {
+            $parameters['json'] = $data;
+        }
+
         return $this->client->request(
             $method,
             $route,
@@ -40,19 +141,104 @@ abstract class OtWebTestCase extends ApiTestCase
      * Send a GET request and return the response parsed content
      *
      * @param string $route
-     * @param array<mixed> $parameters
+     * @param array<mixed> $headers
      * @return ResponseInterface
      */
-    protected function get(string $route, array $parameters = []): ResponseInterface {
+    protected function get(string $route, array $headers = []): ResponseInterface {
         return $this->request(
             Request::METHOD_GET,
             $route,
-            $parameters
+            null,
+            $headers
         );
     }
 
-    protected function validateCollectionSchema(string $resourceClass): void {
-        $this->assertResponseIsSuccessful();
+    /**
+     * Send a PUT request and return the response parsed content
+     *
+     * @param string $route
+     * @param array<mixed> $data
+     * @param array<mixed> $headers
+     * @return ResponseInterface
+     */
+    protected function put(string $route, array $data, array $headers = []): ResponseInterface {
+        return $this->request(
+            Request::METHOD_PUT,
+            $route,
+            $data,
+            $headers
+        );
+    }
+
+    /**
+     * Send a POST request and return the response parsed content
+     *
+     * @param string $route
+     * @param array<mixed> $data
+     * @param array<mixed> $headers
+     * @return ResponseInterface
+     */
+    protected function post(string $route, array $data, array $headers = []): ResponseInterface {
+        return $this->request(
+            Request::METHOD_POST,
+            $route,
+            $data,
+            $headers
+        );
+    }
+
+    /**
+     * Send a DELETE request and return the response parsed content
+     *
+     * @param string $route
+     * @param array<mixed> $headers
+     * @return ResponseInterface
+     */
+    protected function delete(string $route, array $headers = []): ResponseInterface {
+        return $this->request(
+            Request::METHOD_DELETE,
+            $route,
+            null,
+            $headers
+        );
+    }
+
+    /**
+     * Login as the given Access user
+     *
+     * @param Proxy|Access $access
+     * @return void
+     * @throws \Symfony\Contracts\HttpClient\Exception\ClientExceptionInterface
+     * @throws \Symfony\Contracts\HttpClient\Exception\RedirectionExceptionInterface
+     * @throws \Symfony\Contracts\HttpClient\Exception\ServerExceptionInterface
+     * @throws \Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface
+     */
+    protected function loginAs(Proxy | Access $access): void {
+        $person = $access->getPerson();
+
+        $response = $this->post(
+            '/login_check',
+            ['username' => $person->getUsername(), 'password' => $person->getPassword()]
+        );
+        $content = $response->getContent();
+
+        $this->securityToken = json_decode($content)->token;
+        $this->user = $access;
+    }
+
+    /**
+     * Assert that the response has the expected status code and is well formated
+     *
+     * @param string $resourceClass
+     * @param int $expectedStatus
+     * @return void
+     */
+    protected function validateCollectionSchema(string $resourceClass, int $expectedStatus = 200): void {
+        $this->assertResponseStatusCodeSame($expectedStatus);
+
+        if ($expectedStatus == 200) {
+            $this->assertResponseIsSuccessful();
+        }
 
         // Asserts that the returned content type is JSON-LD (the default)
         $this->assertResponseHeaderSame('content-type', 'application/ld+json; charset=utf-8');
@@ -61,5 +247,4 @@ abstract class OtWebTestCase extends ApiTestCase
         // >>> Issue with the json typed PublicStructure::addresses properties
         // $this->assertMatchesResourceCollectionJsonSchema($resourceClass);
     }
-
 }

tests/Application/Person/PersonTest.php

@@ -0,0 +1,90 @@
+<?php
+namespace App\Tests\Application\Person;
+
+use App\Entity\Person\Person;
+use App\Entity\Access\Access;
+use App\Entity\Organization\Organization;
+use App\Entity\Organization\Settings;
+use App\Entity\Public\PublicEvent;
+use App\Enum\Organization\PrincipalTypeEnum;
+use App\Enum\Organization\SettingsProductEnum;
+use App\Tests\Application\OtWebTestCase;
+use App\Tests\Fixture\Factory\Access\AccessFactory;
+use App\Tests\Fixture\Factory\Organization\OrganizationFactory;
+use App\Tests\Fixture\Factory\Organization\SettingsFactory;
+use App\Tests\Fixture\Factory\Person\PersonFactory;
+use App\Tests\Fixture\PersonFixtures;
+use Zenstruck\Foundry\Factory;
+use Zenstruck\Foundry\Proxy;
+use App\Enum\Organization\LegalEnum;
+
+class PersonTest extends OtWebTestCase
+{
+    public function testPersonGet(): void
+    {
+        $this->loginAs($this->user);
+
+        $this->get('/api/people/' . $this->user->getPerson()->getId());
+
+        $this->validateCollectionSchema(Person::class);
+
+        $this->assertJsonContains([
+            '@context' => '/api/contexts/Person',
+            '@id' => '/api/people/' . $this->user->getPerson()->getId(),
+            '@type' => 'Person',
+            'username' => 'username'
+        ]);
+    }
+
+    public function testPersonGetHasNoRole(): void {
+
+        // User has not the required role
+        $this->user->setRoles([]);
+        $this->user->save();
+
+        $this->loginAs($this->user);
+
+        $this->get('/api/people/' . $this->user->getPerson()->getId());
+
+        $this->validateCollectionSchema(Person::class, 403);
+
+        $this->assertJsonContains([
+            "hydra:description" => "Access Denied."
+        ]);
+    }
+
+    public function testPersonGetCollection(): void {
+        $this->loginAs($this->user);
+
+        $this->get('/api/peoples');
+
+        $this->assertResponseStatusCodeSame(404);
+    }
+
+    public function testPersonPut(): void {
+        $this->loginAs($this->user);
+
+        $this->put('/api/people/' . $this->user->getPerson()->getId(), []);
+
+        // Expects : 405 Method Not Allowed
+        $this->assertResponseStatusCodeSame(405);
+    }
+
+    public function testPersonPost(): void {
+        $this->loginAs($this->user);
+
+        $this->post('/api/people/' . $this->user->getPerson()->getId(), []);
+
+        // Expects : 405 Method Not Allowed
+        $this->assertResponseStatusCodeSame(405);
+    }
+
+    public function testPersonDelete(): void {
+        $this->loginAs($this->user);
+
+        $this->delete('/api/people/' . $this->user->getPerson()->getId());
+
+        // Expects : 405 Method Not Allowed
+        $this->assertResponseStatusCodeSame(405);
+    }
+}

tests/Fixture/Factory/Access/AccessFactory.php

@@ -0,0 +1,64 @@
+<?php
+
+namespace App\Tests\Fixture\Factory\Access;
+
+use App\Entity\Access\Access;
+use App\Tests\Fixture\Factory\Person\PersonRepository;
+use Zenstruck\Foundry\RepositoryProxy;
+use Zenstruck\Foundry\ModelFactory;
+use Zenstruck\Foundry\Proxy;
+
+/**
+ * @extends ModelFactory<Access>
+ *
+ * @phpstan-method        Access|Proxy create(array|callable $attributes = [])
+ * @phpstan-method static Access|Proxy createOne(array $attributes = [])
+ * @phpstan-method static Access|Proxy find(object|array|mixed $criteria)
+ * @phpstan-method static Access|Proxy findOrCreate(array $attributes)
+ * @phpstan-method static Access|Proxy first(string $sortedField = 'id')
+ * @phpstan-method static Access|Proxy last(string $sortedField = 'id')
+ * @phpstan-method static Access|Proxy random(array $attributes = [])
+ * @phpstan-method static Access|Proxy randomOrCreate(array $attributes = []))
+ * @phpstan-method static AccessRepository|RepositoryProxy repository()
+ * @phpstan-method static Access[]|Proxy[] all()
+ * @phpstan-method static Access[]|Proxy[] createMany(int $number, array|callable $attributes = [])
+ * @phpstan-method static Access[]&Proxy[] createSequence(iterable|callable $sequence)
+ * @phpstan-method static Access[]|Proxy[] findBy(array $attributes)
+ * @phpstan-method static Access[]|Proxy[] randomRange(int $min, int $max, array $attributes = []))
+ * @phpstan-method static Access[]|Proxy[] randomSet(int $number, array $attributes = []))
+ */
+class AccessFactory extends ModelFactory
+{
+    /**
+     * @see https://github.com/zenstruck/foundry#factories-as-services
+     */
+    public function __construct()
+    {
+        parent::__construct();
+    }
+
+    /**
+     * @see https://github.com/zenstruck/foundry#model-factories
+     *
+     * @todo add your default values here
+     */
+    protected function getDefaults(): array
+    {
+        return [];
+    }
+
+    /**
+     * @see https://github.com/zenstruck/foundry#initialization
+     */
+    protected function initialize(): self
+    {
+        return $this
+            // ->afterInstantiate(function(Post $post) {})
+            ;
+    }
+
+    protected static function getClass(): string
+    {
+        return Access::class;
+    }
+}

tests/Fixture/Factory/Organization/OrganizationFactory.php

@@ -0,0 +1,64 @@
+<?php
+
+namespace App\Tests\Fixture\Factory\Organization;
+
+use App\Entity\Organization\Organization;
+use App\Tests\Fixture\Factory\Person\PersonRepository;
+use Zenstruck\Foundry\RepositoryProxy;
+use Zenstruck\Foundry\ModelFactory;
+use Zenstruck\Foundry\Proxy;
+
+/**
+ * @extends ModelFactory<Organization>
+ *
+ * @phpstan-method        Organization|Proxy create(array|callable $attributes = [])
+ * @phpstan-method static Organization|Proxy createOne(array $attributes = [])
+ * @phpstan-method static Organization|Proxy find(object|array|mixed $criteria)
+ * @phpstan-method static Organization|Proxy findOrCreate(array $attributes)
+ * @phpstan-method static Organization|Proxy first(string $sortedField = 'id')
+ * @phpstan-method static Organization|Proxy last(string $sortedField = 'id')
+ * @phpstan-method static Organization|Proxy random(array $attributes = [])
+ * @phpstan-method static Organization|Proxy randomOrCreate(array $attributes = []))
+ * @phpstan-method static OrganizationRepository|RepositoryProxy repository()
+ * @phpstan-method static Organization[]|Proxy[] all()
+ * @phpstan-method static Organization[]|Proxy[] createMany(int $number, array|callable $attributes = [])
+ * @phpstan-method static Organization[]&Proxy[] createSequence(iterable|callable $sequence)
+ * @phpstan-method static Organization[]|Proxy[] findBy(array $attributes)
+ * @phpstan-method static Organization[]|Proxy[] randomRange(int $min, int $max, array $attributes = []))
+ * @phpstan-method static Organization[]|Proxy[] randomSet(int $number, array $attributes = []))
+ */
+class OrganizationFactory extends ModelFactory
+{
+    /**
+     * @see https://github.com/zenstruck/foundry#factories-as-services
+     */
+    public function __construct()
+    {
+        parent::__construct();
+    }
+
+    /**
+     * @see https://github.com/zenstruck/foundry#model-factories
+     *
+     * @todo add your default values here
+     */
+    protected function getDefaults(): array
+    {
+        return [];
+    }
+
+    /**
+     * @see https://github.com/zenstruck/foundry#initialization
+     */
+    protected function initialize(): self
+    {
+        return $this
+            // ->afterInstantiate(function(Post $post) {})
+            ;
+    }
+
+    protected static function getClass(): string
+    {
+        return Organization::class;
+    }
+}

tests/Fixture/Factory/Organization/SettingsFactory.php

@@ -0,0 +1,64 @@
+<?php
+
+namespace App\Tests\Fixture\Factory\Organization;
+
+use App\Entity\Organization\Settings;
+use App\Tests\Fixture\Factory\Person\PersonRepository;
+use Zenstruck\Foundry\RepositoryProxy;
+use Zenstruck\Foundry\ModelFactory;
+use Zenstruck\Foundry\Proxy;
+
+/**
+ * @extends ModelFactory<Settings>
+ *
+ * @phpstan-method        Settings|Proxy create(array|callable $attributes = [])
+ * @phpstan-method static Settings|Proxy createOne(array $attributes = [])
+ * @phpstan-method static Settings|Proxy find(object|array|mixed $criteria)
+ * @phpstan-method static Settings|Proxy findOrCreate(array $attributes)
+ * @phpstan-method static Settings|Proxy first(string $sortedField = 'id')
+ * @phpstan-method static Settings|Proxy last(string $sortedField = 'id')
+ * @phpstan-method static Settings|Proxy random(array $attributes = [])
+ * @phpstan-method static Settings|Proxy randomOrCreate(array $attributes = []))
+ * @phpstan-method static SettingsRepository|RepositoryProxy repository()
+ * @phpstan-method static Settings[]|Proxy[] all()
+ * @phpstan-method static Settings[]|Proxy[] createMany(int $number, array|callable $attributes = [])
+ * @phpstan-method static Settings[]&Proxy[] createSequence(iterable|callable $sequence)
+ * @phpstan-method static Settings[]|Proxy[] findBy(array $attributes)
+ * @phpstan-method static Settings[]|Proxy[] randomRange(int $min, int $max, array $attributes = []))
+ * @phpstan-method static Settings[]|Proxy[] randomSet(int $number, array $attributes = []))
+ */
+class SettingsFactory extends ModelFactory
+{
+    /**
+     * @see https://github.com/zenstruck/foundry#factories-as-services
+     */
+    public function __construct()
+    {
+        parent::__construct();
+    }
+
+    /**
+     * @see https://github.com/zenstruck/foundry#model-factories
+     *
+     * @todo add your default values here
+     */
+    protected function getDefaults(): array
+    {
+        return [];
+    }
+
+    /**
+     * @see https://github.com/zenstruck/foundry#initialization
+     */
+    protected function initialize(): self
+    {
+        return $this
+            // ->afterInstantiate(function(Post $post) {})
+            ;
+    }
+
+    protected static function getClass(): string
+    {
+        return Settings::class;
+    }
+}

tests/Fixture/Factory/Person/PersonFactory.php

@@ -0,0 +1,63 @@
+<?php
+
+namespace App\Tests\Fixture\Factory\Person;
+
+use App\Entity\Person\Person;
+use Zenstruck\Foundry\RepositoryProxy;
+use Zenstruck\Foundry\ModelFactory;
+use Zenstruck\Foundry\Proxy;
+
+/**
+ * @extends ModelFactory<Person>
+ *
+ * @phpstan-method        Person|Proxy create(array|callable $attributes = [])
+ * @phpstan-method static Person|Proxy createOne(array $attributes = [])
+ * @phpstan-method static Person|Proxy find(object|array|mixed $criteria)
+ * @phpstan-method static Person|Proxy findOrCreate(array $attributes)
+ * @phpstan-method static Person|Proxy first(string $sortedField = 'id')
+ * @phpstan-method static Person|Proxy last(string $sortedField = 'id')
+ * @phpstan-method static Person|Proxy random(array $attributes = [])
+ * @phpstan-method static Person|Proxy randomOrCreate(array $attributes = []))
+ * @phpstan-method static PersonRepository|RepositoryProxy repository()
+ * @phpstan-method static Person[]|Proxy[] all()
+ * @phpstan-method static Person[]|Proxy[] createMany(int $number, array|callable $attributes = [])
+ * @phpstan-method static Person[]&Proxy[] createSequence(iterable|callable $sequence)
+ * @phpstan-method static Person[]|Proxy[] findBy(array $attributes)
+ * @phpstan-method static Person[]|Proxy[] randomRange(int $min, int $max, array $attributes = []))
+ * @phpstan-method static Person[]|Proxy[] randomSet(int $number, array $attributes = []))
+ */
+class PersonFactory extends ModelFactory
+{
+    /**
+     * @see https://github.com/zenstruck/foundry#factories-as-services
+     */
+    public function __construct()
+    {
+        parent::__construct();
+    }
+
+    /**
+     * @see https://github.com/zenstruck/foundry#model-factories
+     *
+     * @todo add your default values here
+     */
+    protected function getDefaults(): array
+    {
+        return [];
+    }
+
+    /**
+     * @see https://github.com/zenstruck/foundry#initialization
+     */
+    protected function initialize(): self
+    {
+        return $this
+            // ->afterInstantiate(function(Post $post) {})
+            ;
+    }
+
+    protected static function getClass(): string
+    {
+        return Person::class;
+    }
+}

tests/Fixture/PersonFixtures.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace App\Tests\Fixture;
+
+use App\Entity\Booking\Event;
+use App\Entity\Core\ContactPoint;
+use App\Entity\Network\Network;
+use App\Entity\Network\NetworkOrganization;
+use App\Entity\Organization\Organization;
+use App\Entity\Organization\Parameters;
+use App\Entity\Person\Person;
+use App\Enum\Booking\VisibilityEnum;
+use App\Enum\Core\ContactPointTypeEnum;
+use App\Enum\Organization\LegalEnum;
+use App\Enum\Organization\PrincipalTypeEnum;
+use App\Tests\Fixture\Factory\Person\PersonFactory;
+use Doctrine\Bundle\FixturesBundle\Fixture;
+use Doctrine\Persistence\ObjectManager;
+use Symfony\Component\Serializer\Context\SerializerContextBuilder;
+use App\Service\Utils\Uuid;
+use Zenstruck\Foundry\Factory;
+
+class PersonFixtures extends Fixture
+{
+    public function load(ObjectManager $em): void
+    {
+        PersonFactory::createMany(10, static function() {
+            return [
+                'username' => Factory::faker()->name()
+            ];});
+
+        $em->flush();
+    }
+}

tests/Unit/Service/Access/AccessProfileCreatorTest.php

@@ -382,7 +382,7 @@ class AccessProfileCreatorTest extends TestCase
         $this->assertEquals('MR', $accessProfile->getGender());
         $this->assertEquals(2020, $accessProfile->getActivityYear());
         $this->assertEquals(123, $accessProfile->getAvatarId());
-        $this->assertEquals(false, $accessProfile->getIsSuperAdminAccess());
+        $this->assertFalse($accessProfile->getIsSuperAdminAccess());
         $this->assertEquals($this->organizationProfile, $accessProfile->getOrganization());
     }
 }

tests/Unit/Service/Dolibarr/DolibarrAccountCreatorTest.php

@@ -203,6 +203,6 @@ class DolibarrAccountCreatorTest extends TestCase
         $this->assertEquals('foo', $dolibarrBill->getRef());
         $this->assertEquals(100.0, $dolibarrBill->getTaxExcludedAmount());
         $this->assertEquals(120.0, $dolibarrBill->getTaxIncludedAmount());
-        $this->assertEquals(false, $dolibarrBill->getPaid());
+        $this->assertFalse($dolibarrBill->getPaid());
     }
 }

tests/Unit/Service/Export/LicenceCmfExporterTest.php

@@ -157,7 +157,7 @@ class LicenceCmfExporterTest extends TestCase
         $qrCode = $this->getMockBuilder(File::class)->getMock();
 
         $this->assertEquals('my_network', $licence->getFederationName());
-        $this->assertEquals(true, $licence->isOrganizationLicence());
+        $this->assertTrue($licence->isOrganizationLicence());
         $this->assertEquals(2020, $licence->getYear());
         $this->assertEquals('931572', $licence->getColor());
         $this->assertEquals($qrCode, $licence->getQrCode());

tests/Unit/Service/Export/Model/LicenceCmfTest.php

@@ -64,7 +64,7 @@ class LicenceCmfTest extends TestCase
 
         $this->assertEquals(1, $model->getId());
         $this->assertEquals(2020, $model->getYear());
-        $this->assertEquals(true, $model->isOrganizationLicence());
+        $this->assertTrue($model->isOrganizationLicence());
         $this->assertEquals('foo', $model->getOrganizationName());
         $this->assertEquals('123', $model->getOrganizationIdentifier());
         $this->assertEquals('bar', $model->getFederationName());

tests/Unit/Service/File/Storage/LocalStorageTest.php

@@ -162,7 +162,7 @@ class LocalStorageTest extends TestCase
         $this->assertEquals('file.ext', $file->getName());
         $this->assertEquals(null, $file->getSlug());
         $this->assertEquals(FileTypeEnum::LICENCE_CMF()->getValue(), $file->getType());
-        $this->assertEquals(true, $file->getIsTemporaryFile());
+        $this->assertTrue($file->getIsTemporaryFile());
         $this->assertEquals('ONLY_ORGANIZATION', $file->getVisibility());
         $this->assertEquals('application/pdf', $file->getMimeType());
         $this->assertEquals(123, $file->getCreatedBy());
@@ -193,7 +193,7 @@ class LocalStorageTest extends TestCase
         $this->assertEquals($owner, $file->getPerson());
         $this->assertEquals('file.txt', $file->getName());
         $this->assertEquals(FileTypeEnum::NONE()->getValue(), $file->getType());
-        $this->assertEquals(false, $file->getIsTemporaryFile());
+        $this->assertFalse($file->getIsTemporaryFile());
         $this->assertEquals('NOBODY', $file->getVisibility());
         $this->assertEquals('text/plain', $file->getMimeType());
     }

tests/Unit/Service/MercureHubTest.php

@@ -43,7 +43,7 @@ class MercureHubTest extends TestCase
 
         $this->assertEquals(['access/1'], $update->getTopics());
         $this->assertEquals("{'foo': 1}", $update->getData());
-        $this->assertEquals(true, $update->isPrivate());
+        $this->assertTrue($update->isPrivate());
     }
 
     /**