Browse Source

add phpstan and minor fixes

Olivier Massot 3 years ago
parent
commit
07a06ea04a

+ 1 - 0
composer.json

@@ -65,6 +65,7 @@
     },
     "require-dev": {
         "cyclonedx/cyclonedx-php-composer": "^3.4",
+        "phpstan/phpstan": "^1.9",
         "rector/rector": "^0.12",
         "symfony/debug-bundle": "5.4.*",
         "symfony/maker-bundle": "^1.21",

+ 5 - 0
config/packages/debug.yaml

@@ -0,0 +1,5 @@
+when@dev:
+    debug:
+        # Forwards VarDumper Data clones to a centralized server allowing to inspect dumps on CLI or in your browser.
+        # See the "server:dump" command to start a new server.
+        dump_destination: "tcp://%env(VAR_DUMPER_SERVER)%"

+ 61 - 0
config/packages/monolog.yaml

@@ -0,0 +1,61 @@
+monolog:
+    channels:
+        - deprecation # Deprecations are logged in the dedicated "deprecation" channel when it exists
+
+when@dev:
+    monolog:
+        handlers:
+            main:
+                type: stream
+                path: "%kernel.logs_dir%/%kernel.environment%.log"
+                level: debug
+                channels: ["!event"]
+            # uncomment to get logging in your browser
+            # you may have to allow bigger header sizes in your Web server configuration
+            #firephp:
+            #    type: firephp
+            #    level: info
+            #chromephp:
+            #    type: chromephp
+            #    level: info
+            console:
+                type: console
+                process_psr_3_messages: false
+                channels: ["!event", "!doctrine", "!console"]
+
+when@test:
+    monolog:
+        handlers:
+            main:
+                type: fingers_crossed
+                action_level: error
+                handler: nested
+                excluded_http_codes: [404, 405]
+                channels: ["!event"]
+            nested:
+                type: stream
+                path: "%kernel.logs_dir%/%kernel.environment%.log"
+                level: debug
+
+when@prod:
+    monolog:
+        handlers:
+            main:
+                type: fingers_crossed
+                action_level: error
+                handler: nested
+                excluded_http_codes: [404, 405]
+                buffer_size: 50 # How many messages should be saved? Prevent memory leaks
+            nested:
+                type: stream
+                path: php://stderr
+                level: debug
+                formatter: monolog.formatter.json
+            console:
+                type: console
+                process_psr_3_messages: false
+                channels: ["!event", "!doctrine"]
+            deprecation:
+                type: stream
+                channels: [deprecation]
+                path: php://stderr

+ 15 - 0
config/packages/web_profiler.yaml

@@ -0,0 +1,15 @@
+when@dev:
+    web_profiler:
+        toolbar: true
+        intercept_redirects: false
+
+    framework:
+        profiler: { only_exceptions: false }
+
+when@test:
+    web_profiler:
+        toolbar: false
+        intercept_redirects: false
+
+    framework:
+        profiler: { collect: false }

+ 4 - 0
config/routes/framework.yaml

@@ -0,0 +1,4 @@
+when@dev:
+    _errors:
+        resource: '@FrameworkBundle/Resources/config/routing/errors.xml'
+        prefix: /_error

+ 8 - 0
config/routes/web_profiler.yaml

@@ -0,0 +1,8 @@
+when@dev:
+    web_profiler_wdt:
+        resource: '@WebProfilerBundle/Resources/config/routing/wdt.xml'
+        prefix: /_wdt
+
+    web_profiler_profiler:
+        resource: '@WebProfilerBundle/Resources/config/routing/profiler.xml'
+        prefix: /_profiler

+ 6 - 0
phpstan.neon

@@ -0,0 +1,6 @@
+# https://phpstan.org/config-reference
+parameters:
+	level: 5
+	paths:
+		- src
+		- tests

+ 9 - 0
readme.md

@@ -15,3 +15,12 @@ Pour consommer les signaux messengers, lancer :
     php bin/console messenger:consume async
 
 > Voir: <https://symfony.com/doc/5.4/messenger.html#consuming-messages-running-the-worker>
+
+## Chercher les erreurs avec phpstan
+
+Pour exécuter une analyse du code :
+
+    vendor/bin/phpstan analyse
+
+> Voir : https://phpstan.org/user-guide/getting-started
+

+ 6 - 6
src/Service/Export/Model/LicenceCmf.php

@@ -93,7 +93,7 @@ class LicenceCmf implements ExportModelInterface
      *
      * @var File|null
      */
-    private ?File $personAvatarUri = null;
+    private ?File $personAvatar = null;
 
     /**
      * @return int
@@ -345,18 +345,18 @@ class LicenceCmf implements ExportModelInterface
     /**
      * @return File|null
      */
-    public function getPersonAvatarUri(): ?File
+    public function getPersonAvatar(): ?File
     {
-        return $this->personAvatarUri;
+        return $this->personAvatar;
     }
 
     /**
-     * @param File|null $personAvatarUri
+     * @param File|null $personAvatar
      * @return LicenceCmf
      */
-    public function setPersonAvatarUri(?File $personAvatarUri): LicenceCmf
+    public function setPersonAvatar(?File $personAvatar): LicenceCmf
     {
-        $this->personAvatarUri = $personAvatarUri;
+        $this->personAvatar = $personAvatar;
 
         return $this;
     }

+ 0 - 0
tests/Service/Storage/ApiLegacyStorageTest.php → tests/Service/File/Storage/ApiLegacyStorageTest.php


+ 0 - 0
tests/Service/Storage/LocalStorageTest.php → tests/Service/File/Storage/LocalStorageTest.php